feat(test-suite): implement the delegated user decryption test cases

[isaacdecoded]

E2E tests passing here: https://github.com/zama-ai/fhevm/actions/runs/21517026053/job/61997853269

Closes https://github.com/zama-ai/fhevm-internal/issues/889

[mergify]

🧪 CI Insights

Here's what we observed from your CI run for 96ff2a2.

🟢 All jobs passed!

But CI Insights is watching 👀

[jatZama]

I am not sure to fully understand the example inside test-suite/e2e/contracts/DelegateUserDecryptDelegator.sol
It is a bit contrived, there are so many allowances, on 4 different accounts (msg.sender, address(this), delegate, delegator).

What an ideal test would have been in my mind is something more like a smart contract account (i.e could be just a SAFE with one owner, or even more recommended the SimpleMultiSig example here https://github.com/zama-ai/fhevm/blob/main/library-solidity/examples/multisig/SimpleMultiSig.sol that you could initialize with one unique owner) receiving some amount of confidential tokens for eg. Then the owner of the multisig, would call his multisig to call the ACL:delegate function, to make his EOA able to read the confidential balance of his SimpleMultiSig account. This seems more natural example for me.

Maybe you can keep current test but also at least add one more "realistic" example, such as the one with SimpleMultiSig receiving some confidential amount as proposed here. Wdyt?

[isaacdecoded]

I am not sure to fully understand the example inside test-suite/e2e/contracts/DelegateUserDecryptDelegator.sol It is a bit contrived, there are so many allowances, on 4 different accounts (msg.sender, address(this), delegate, delegator).

What an ideal test would have been in my mind is something more like a smart contract account (i.e could be just a SAFE with one owner, or even more recommended the SimpleMultiSig example here https://github.com/zama-ai/fhevm/blob/main/library-solidity/examples/multisig/SimpleMultiSig.sol that you could initialize with one unique owner) receiving some amount of confidential tokens for eg. Then the owner of the multisig, would call his multisig to call the ACL:delegate function, to make his EOA able to read the confidential balance of his SimpleMultiSig account. This seems more natural example for me.

Maybe you can keep current test but also at least add one more "realistic" example, such as the one with SimpleMultiSig receiving some confidential amount as proposed here. Wdyt?

Adjusted the test cases following your suggestions on this commit, thanks a lot!

[jatZama]

Great new example, I would just rename the MultiSigWithDelegation contract to SmartWalletWithDelegation or something. Thanks!

[isaacdecoded]

@Mergifyio queue

[mergify]

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at ab21177

[mergify]

Merge Queue Status

✅ The pull request has been merged at 96ff2a2

This pull request spent 1 hour 36 minutes 1 second in the queue, including 25 minutes 59 seconds running CI.
The checks were run on draft #1866.

Required conditions to merge

• #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • feat(test-suite): implement the delegated user decryption test cases #1808
• #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • feat(test-suite): implement the delegated user decryption test cases #1808
• #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • feat(test-suite): implement the delegated user decryption test cases #1808
• branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
  • feat(test-suite): implement the delegated user decryption test cases #1808
• check-success = run-e2e-tests / fhevm-e2e-test
• any of [🛡 GitHub branch protection]:
  • check-success = common-pull-request/lint (bpr)
  • check-neutral = common-pull-request/lint (bpr)
  • check-skipped = common-pull-request/lint (bpr)
• any of [🛡 GitHub branch protection]:
  • check-skipped = coprocessor-cargo-listener-tests/cargo-tests (bpr)
  • check-neutral = coprocessor-cargo-listener-tests/cargo-tests (bpr)
  • check-success = coprocessor-cargo-listener-tests/cargo-tests (bpr)
• any of [🛡 GitHub branch protection]:
  • check-skipped = coprocessor-cargo-test/cargo-tests (bpr)
  • check-neutral = coprocessor-cargo-test/cargo-tests (bpr)
  • check-success = coprocessor-cargo-test/cargo-tests (bpr)
• any of [🛡 GitHub branch protection]:
  • check-skipped = coprocessor-dependency-analysis/dependencies-check (bpr)
  • check-neutral = coprocessor-dependency-analysis/dependencies-check (bpr)
  • check-success = coprocessor-dependency-analysis/dependencies-check (bpr)
• any of [🛡 GitHub branch protection]:
  • check-skipped = gateway-contracts-deployment-tests/sc-deploy (bpr)
  • check-neutral = gateway-contracts-deployment-tests/sc-deploy (bpr)
  • check-success = gateway-contracts-deployment-tests/sc-deploy (bpr)
• any of [🛡 GitHub branch protection]:
  • check-skipped = kms-connector-tests/test-connector (bpr)
  • check-neutral = kms-connector-tests/test-connector (bpr)
  • check-success = kms-connector-tests/test-connector (bpr)