Skip to content

fix(coprocessor): make ciphertext compression fallible#1928

Merged
mergify[bot] merged 8 commits intomainfrom
codex/fix-compress-fallible-1020
Feb 9, 2026
Merged

fix(coprocessor): make ciphertext compression fallible#1928
mergify[bot] merged 8 commits intomainfrom
codex/fix-compress-fallible-1020

Conversation

@Eikix
Copy link
Copy Markdown
Contributor

@Eikix Eikix commented Feb 6, 2026

Summary

This is the standalone fix for zama-ai/fhevm-internal#1020.

  • Make SupportedFheCiphertexts::compress() fallible and remove panic/expect usage.
  • Convert TFHE compression failures (including panic payloads from internal asserts) into typed FhevmError values.
  • Bubble compression errors at caller sites instead of killing execution:
    • scheduler compression paths
    • tfhe-worker server compression paths
    • zkproof-worker handle creation path
  • Add a focused unit test for scalar compression error behavior.

Scope

Compression error propagation only.
No gRPC-refactor changes, no unrelated cleanup.

Validation

  • cd coprocessor/fhevm-engine && SQLX_OFFLINE=true cargo check -p fhevm-engine-common -p scheduler -p zkproof-worker -p tfhe-worker
  • cd coprocessor/fhevm-engine && SQLX_OFFLINE=true cargo test -p fhevm-engine-common -p scheduler -p zkproof-worker -p tfhe-worker --no-run
  • cd coprocessor/fhevm-engine && SQLX_OFFLINE=true cargo test -p fhevm-engine-common compress_scalar_returns_error -- --nocapture

closes https://github.com/zama-ai/fhevm-internal/issues/1020

@Eikix Eikix requested a review from a team as a code owner February 6, 2026 12:46
@cla-bot cla-bot bot added the cla-signed label Feb 6, 2026
@Eikix Eikix changed the title fix(fhevm-engine): make ciphertext compression fallible fix(coprocessor): make ciphertext compression fallible Feb 6, 2026
@mergify
Copy link
Copy Markdown

mergify bot commented Feb 6, 2026

🧪 CI Insights

Here's what we observed from your CI run for 1ddbdc2.

🟢 All jobs passed!

But CI Insights is watching 👀

@Eikix Eikix force-pushed the codex/fix-compress-fallible-1020 branch from 2cd9101 to 1ddbdc2 Compare February 9, 2026 08:19
@Eikix
Copy link
Copy Markdown
Contributor Author

Eikix commented Feb 9, 2026

normally ready for re review

@Eikix
Copy link
Copy Markdown
Contributor Author

Eikix commented Feb 9, 2026

@mergify queue

@mergify
Copy link
Copy Markdown

mergify bot commented Feb 9, 2026

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at bed88b0

@mergify
Copy link
Copy Markdown

mergify bot commented Feb 9, 2026

Merge Queue Status

Rule: main


This pull request spent 2 hours 41 minutes 4 seconds in the queue, including 9 hours 54 minutes 56 seconds running CI.

Required conditions to merge

@mergify mergify bot added the queued label Feb 9, 2026
mergify bot added a commit that referenced this pull request Feb 9, 2026
@mergify mergify bot merged commit bed88b0 into main Feb 9, 2026
62 checks passed
@mergify mergify bot removed the queued label Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants