Skip to content

chore(common): enable rs typos checks#1956

Merged
mergify[bot] merged 4 commits intomainfrom
codex/issue-1910-rs-typos
Feb 13, 2026
Merged

chore(common): enable rs typos checks#1956
mergify[bot] merged 4 commits intomainfrom
codex/issue-1910-rs-typos

Conversation

@Eikix
Copy link
Copy Markdown
Contributor

@Eikix Eikix commented Feb 10, 2026

Summary

  • remove *.rs from extend-exclude in typos.toml
  • fix all Rust typos reported by typos
  • keep the change scoped to typos.toml + .rs files only

Testing

  • typos
  • pre-commit hook checks for coprocessor (auto-run on commit):
    • cargo fmt --check
    • cargo check
    • cargo clippy -- -D warnings -D clippy::all -D clippy::pedantic
  • cargo check in test-suite/gateway-stress
  • cargo check in kms-connector

Closes #1910

@Eikix Eikix requested review from a team and dartdart26 as code owners February 10, 2026 14:11
@cla-bot cla-bot Bot added the cla-signed label Feb 10, 2026
eudelins-zama
eudelins-zama previously approved these changes Feb 10, 2026
Copy link
Copy Markdown
Contributor

@eudelins-zama eudelins-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on connector side, thanks!

@eudelins-zama
Copy link
Copy Markdown
Contributor

FYI, the error in the rust-sdk CI is expected, see https://github.com/zama-ai/fhevm-internal/issues/1024.

MPC team identified a regression on their side, will handle this as soon as it's fixed in the kms codebase

@Eikix
Copy link
Copy Markdown
Contributor Author

Eikix commented Feb 10, 2026

Follow-up done: I reverted the randomise/randomisation rewrites and added these British variants to typos.toml allowlist:

  • randomise, randomised, randomising, randomisation
  • rerandomise, rerandomised, rerandomising, rerandomisation

So typo checks stay strict, but we don't enforce US spelling for this vocabulary.

@mergify
Copy link
Copy Markdown

mergify Bot commented Feb 10, 2026

🧪 CI Insights

Here's what we observed from your CI run for b7e0195.

🟢 All jobs passed!

But CI Insights is watching 👀

@Eikix Eikix force-pushed the codex/issue-1910-rs-typos branch from 21f16bf to 36f99f4 Compare February 12, 2026 15:49
eudelins-zama
eudelins-zama previously approved these changes Feb 12, 2026
Copy link
Copy Markdown
Contributor

@eudelins-zama eudelins-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again

@Eikix
Copy link
Copy Markdown
Contributor Author

Eikix commented Feb 12, 2026

@mergify queue

@mergify
Copy link
Copy Markdown

mergify Bot commented Feb 12, 2026

Merge Queue Status

🛑 Queue command has been cancelled

@Eikix
Copy link
Copy Markdown
Contributor Author

Eikix commented Feb 13, 2026

@mergify requeue

@mergify
Copy link
Copy Markdown

mergify Bot commented Feb 13, 2026

requeue

☑️ This pull request is already queued

@Eikix
Copy link
Copy Markdown
Contributor Author

Eikix commented Feb 13, 2026

@mergify dequeue

@Eikix
Copy link
Copy Markdown
Contributor Author

Eikix commented Feb 13, 2026

@mergify queue

@mergify
Copy link
Copy Markdown

mergify Bot commented Feb 13, 2026

Merge Queue Status

Rule: main


This pull request spent 3 hours 7 minutes 3 seconds in the queue, including 2 hours 38 minutes 8 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
  • check-success = run-e2e-tests / fhevm-e2e-test
  • any of [🛡 GitHub branch protection]:
    • check-success = common-pull-request/lint (bpr)
    • check-neutral = common-pull-request/lint (bpr)
    • check-skipped = common-pull-request/lint (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-skipped = coprocessor-cargo-listener-tests/cargo-tests (bpr)
    • check-neutral = coprocessor-cargo-listener-tests/cargo-tests (bpr)
    • check-success = coprocessor-cargo-listener-tests/cargo-tests (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-success = coprocessor-cargo-test/cargo-tests (bpr)
    • check-neutral = coprocessor-cargo-test/cargo-tests (bpr)
    • check-skipped = coprocessor-cargo-test/cargo-tests (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-success = coprocessor-dependency-analysis/dependencies-check (bpr)
    • check-neutral = coprocessor-dependency-analysis/dependencies-check (bpr)
    • check-skipped = coprocessor-dependency-analysis/dependencies-check (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-skipped = gateway-contracts-deployment-tests/sc-deploy (bpr)
    • check-neutral = gateway-contracts-deployment-tests/sc-deploy (bpr)
    • check-success = gateway-contracts-deployment-tests/sc-deploy (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-success = kms-connector-tests/test-connector (bpr)
    • check-neutral = kms-connector-tests/test-connector (bpr)
    • check-skipped = kms-connector-tests/test-connector (bpr)

@mergify mergify Bot added the merge-queued label Feb 13, 2026
@mergify mergify Bot added the queued label Feb 13, 2026
mergify Bot added a commit that referenced this pull request Feb 13, 2026
@mergify mergify Bot removed the merge-queued label Feb 13, 2026
mergify Bot added a commit that referenced this pull request Feb 13, 2026
mergify Bot added a commit that referenced this pull request Feb 13, 2026
mergify Bot added a commit that referenced this pull request Feb 13, 2026
@mergify mergify Bot merged commit 8225f4e into main Feb 13, 2026
62 checks passed
@mergify mergify Bot deleted the codex/issue-1910-rs-typos branch February 13, 2026 13:06
@mergify mergify Bot removed the queued label Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove typos ignore for .rs and fix typos

3 participants