fix(coprocessor): decompress all ciphertexts per operation#2035
Closed
fix(coprocessor): decompress all ciphertexts per operation#2035
Conversation
🧪 CI InsightsHere's what we observed from your CI run for ffa590d. 🟢 All jobs passed!But CI Insights is watching 👀 |
0133911 to
db0435b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes zama-ai/fhevm-internal#1086
Summary
Rebuild this fix from
mainwith a single focused change:force ciphertext dependencies through a compressed-at-hop path, and decompress only at operation execution.
This aligns with the updated consensus model:
compress/decompressandrerandare both representation-changing transforms and must be on the same deterministic path.What changed
coprocessor/fhevm-engine/scheduler/src/dfg/scheduler.rsDFGTxInput::Compressedtry_execute_node, accept compressed task inputs and decompress right before rerand/computerun_computation, always compress operation outputs (not only allowed)coprocessor/fhevm-engine/scheduler/src/dfg.rs(ct_type, compressed_ct)payloadcoprocessor/fhevm-engine/scheduler/src/dfg/types.rsTaskResultto compressed payload only:ct_typecompressed_ctis_allowedtransaction_idDeterministic path now
For ciphertext dependencies:
compressed -> decompress -> rerand -> compute -> compressValidation