chore(kms-connector): avoid redundant acl check#2041
Merged
mergify[bot] merged 2 commits intomainfrom Mar 24, 2026
Merged
Conversation
🧪 CI InsightsHere's what we observed from your CI run for c19a4b9. 🟢 All jobs passed!But CI Insights is watching 👀 |
eudelins-zama
force-pushed
the
eudelins/chore/1129/avoid-redundant-acl-check
branch
from
c19a4b9 to
598cce4
Compare
Contributor
Author
|
@Mergifyio queue |
Merge Queue Status🛑 Queue command has been cancelled |
There was a problem hiding this comment.
Pull request overview
This PR optimizes delegated user decryption ACL validation in the KMS worker by removing redundant on-chain ACL calls and relying on a single contract method that already encodes the needed checks.
Changes:
- Simplifies delegated user decryption ACL checks to a single
isHandleDelegatedForUserDecryptioncall. - Removes now-redundant
isAllowedchecks for delegator and contract in the delegated path. - Updates the delegated-user-decryption unit tests to reflect the reduced number of mocked ACL calls.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@Mergifyio queue |
Merge Queue Status
This pull request spent 1 hour 41 minutes 55 seconds in the queue, including 41 minutes 15 seconds running CI. Required conditions to merge
|
This was referenced Mar 24, 2026
eudelins-zama
added a commit
that referenced
this pull request
Mar 24, 2026
* chore(kms-connector): avoid redundant acl check * fix(kms-connector): fix acl tests
eudelins-zama
added a commit
that referenced
this pull request
Mar 25, 2026
* chore(kms-connector): avoid redundant acl check (#2041) * chore(kms-connector): avoid redundant acl check * fix(kms-connector): fix acl tests * chore(kms-connector): remove check decryption already done (#2030) * chore(kms-connector): remove check decryption already done * chore(kms-connector): remove useless mock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/zama-ai/fhevm-internal/issues/1129