fix(test-suite): fix delegated user decrypt assertion#2070
fix(test-suite): fix delegated user decrypt assertion#2070
Conversation
🧪 CI InsightsHere's what we observed from your CI run for ab6d3c1. 🟢 All jobs passed!But CI Insights is watching 👀 |
| // Wait for 2 blocks to ensure delegation is propagated by the coprocessor. | ||
| const currentBlock = await ethers.provider.getBlockNumber(); | ||
| await waitForBlock(currentBlock + 15); | ||
| await waitForBlock(currentBlock + 2); |
There was a problem hiding this comment.
Do you know why this got decremented to 2 blocks? Is the simple ACL already working maybe?
There was a problem hiding this comment.
With 15 blocks we hit the timeout for the last test, as we wait for 15 blocks twice.
Not sure for simple ACL, as this tested for v0.11.
There was a problem hiding this comment.
I would appreciate if we could merge #2072 first, to avoid dealing with conflicts on a big long living feature branch 😇
There was a problem hiding this comment.
Simple ACL changes are not yet active on main.
The error matching would again change with simple ACL, as the check will be have a new error label for Host ACL related errors.
There was a problem hiding this comment.
I agree with @eudlins-zama that we should merge the feature branch sooner.
There was a problem hiding this comment.
Since simple ACL is on main, what is the next step on this PR?
There was a problem hiding this comment.
@Eikix There were 2 main issues that this PR is resolving:
- Enough timeout for real blockchain networks
- Reject with the correct Error message
With simple ACL, we still need 1, but not sure if 2 was fixed
There was a problem hiding this comment.
So the PR is good to merge as is? or it needs rework?
5 participants
No description provided.