Skip to content

feat(coprocessor): speed up CI#2174

Merged
mergify[bot] merged 5 commits intomainfrom
antoniu/mold-linker
Mar 26, 2026
Merged

feat(coprocessor): speed up CI#2174
mergify[bot] merged 5 commits intomainfrom
antoniu/mold-linker

Conversation

@antoniupop
Copy link
Copy Markdown
Collaborator

To speed up compilation times in CI

@cla-bot cla-bot bot added the cla-signed label Mar 25, 2026
@antoniupop antoniupop force-pushed the antoniu/mold-linker branch from 2d60006 to bd8385f Compare March 25, 2026 13:04
@antoniupop antoniupop changed the title feat(ci): use mold linker feat(coprocessor): speed up CI Mar 25, 2026
@antoniupop antoniupop force-pushed the antoniu/mold-linker branch from bd8385f to 0bd07ee Compare March 25, 2026 13:14
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

Changed Lines Coverage

Coverage of added/modified lines: N/A

@antoniupop antoniupop force-pushed the antoniu/mold-linker branch 2 times, most recently from 73daa1d to e78d3d8 Compare March 25, 2026 15:06
@antoniupop antoniupop force-pushed the antoniu/mold-linker branch from e78d3d8 to b7c94e6 Compare March 25, 2026 15:07
@antoniupop antoniupop marked this pull request as ready for review March 25, 2026 15:07
@antoniupop antoniupop requested a review from a team as a code owner March 25, 2026 15:07
@antoniupop antoniupop requested a review from PanGan21 March 25, 2026 15:07
claude[bot]

This comment was marked as resolved.

@antoniupop antoniupop force-pushed the antoniu/mold-linker branch from b7c94e6 to 48be2f7 Compare March 25, 2026 15:27
@zama-ai zama-ai deleted a comment from claude bot Mar 25, 2026
@zama-ai zama-ai deleted a comment from claude bot Mar 25, 2026
@antoniupop
Copy link
Copy Markdown
Collaborator Author

@claude /pr-review

@claude
Copy link
Copy Markdown

claude bot commented Mar 25, 2026

Claude finished @antoniupop's request.View run

Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[AUTOMATED]

Code Review

Summary

This PR improves CI performance through two key optimizations:

  1. Mold linker — Uses mold (via clang) as the linker for the cargo-tests workflow, which is significantly faster than the default ld.
  2. Parallelized DB migration — Starts database migration in the background early, compiles tests with SQLX_OFFLINE=true while the DB initializes, then waits for migration before running tests.

The approach is sound — it mirrors the existing make init_db target (docker compose up -d --build db-migration && docker wait db-migration) but splits it into start/wait phases with compilation in between.

Reviewed For

  • ✅ Bugs and runtime correctness
  • ✅ Error handling and silent failures
  • ✅ Guideline compliance and pattern consistency

Findings

One minor observation posted inline. No blocking issues found.

Overall this is a clean, well-structured CI optimization. The wait logic has proper timeout handling, exit code checking, and diagnostic log output.

@claude
Copy link
Copy Markdown

claude bot commented Mar 25, 2026

The review has been posted successfully. Here's a summary of the review:

PR Review Summary — PR #2174: feat(coprocessor): speed up CI

What the PR Does

Two CI optimizations:

  1. Mold linker — Configures the faster mold linker (via clang) for the cargo-tests workflow
  2. Parallelized DB migration — Starts database migration in the background early, compiles tests with SQLX_OFFLINE=true while the DB initializes, then waits for migration completion before running tests

Review Results

  • Bugs: No blocking bugs found. The container name db-migration is correctly referenced (confirmed via container_name: in docker-compose.yml). The parallelization strategy is sound — SQLX_OFFLINE=true correctly allows compilation without a live DB.
  • Error Handling: The wait logic has proper timeout handling (15 min), exit code checking, and diagnostic log output on failure. Well done.
  • Guideline Compliance: No violations found. No CLAUDE.md or style guide exists in the repo.
  • 1 Nit posted inline: The nohup wrapper around docker compose up -d --build is redundant in CI — nohup guards against HUP signals which don't apply in GitHub Actions. The & is the useful part. Non-blocking suggestion.

@antoniupop antoniupop force-pushed the antoniu/mold-linker branch from 796be4e to fbacbc8 Compare March 25, 2026 16:00
@antoniupop antoniupop requested a review from PanGan21 March 25, 2026 16:19
@antoniupop antoniupop force-pushed the antoniu/mold-linker branch from f8e1d3e to aef53df Compare March 25, 2026 19:35
@antoniupop
Copy link
Copy Markdown
Collaborator Author

@Mergifyio queue

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 26, 2026

Merge Queue Status

This pull request spent 2 hours 41 minutes 10 seconds in the queue, including 1 hour 39 minutes 52 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
  • check-success = run-e2e-tests / fhevm-e2e-test
  • any of [🛡 GitHub branch protection]:
    • check-success = common-pull-request/lint (bpr)
    • check-neutral = common-pull-request/lint (bpr)
    • check-skipped = common-pull-request/lint (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-success = coprocessor-cargo-test/cargo-tests (bpr)
    • check-neutral = coprocessor-cargo-test/cargo-tests (bpr)
    • check-skipped = coprocessor-cargo-test/cargo-tests (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-skipped = coprocessor-dependency-analysis/dependencies-check (bpr)
    • check-neutral = coprocessor-dependency-analysis/dependencies-check (bpr)
    • check-success = coprocessor-dependency-analysis/dependencies-check (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-skipped = gateway-contracts-deployment-tests/sc-deploy (bpr)
    • check-neutral = gateway-contracts-deployment-tests/sc-deploy (bpr)
    • check-success = gateway-contracts-deployment-tests/sc-deploy (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-skipped = kms-connector-tests/test-connector (bpr)
    • check-neutral = kms-connector-tests/test-connector (bpr)
    • check-success = kms-connector-tests/test-connector (bpr)

@mergify mergify bot added the queued label Mar 26, 2026
mergify bot added a commit that referenced this pull request Mar 26, 2026
@mergify mergify bot merged commit 73e9e30 into main Mar 26, 2026
63 of 64 checks passed
@mergify mergify bot deleted the antoniu/mold-linker branch March 26, 2026 08:55
mergify bot added a commit that referenced this pull request Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants