Skip to content

fix(coprocessor): do not retry on VerifyProofNotRequested#2206

Merged
mergify[bot] merged 1 commit intomainfrom
petar/verify-proof-not-req
Mar 30, 2026
Merged

fix(coprocessor): do not retry on VerifyProofNotRequested#2206
mergify[bot] merged 1 commit intomainfrom
petar/verify-proof-not-req

Conversation

@dartdart26
Copy link
Copy Markdown
Collaborator

If VerifyProofNotRequested is returned, the txn-sender should not retry as it can never succeed. This error is not supposed to happen, but it is better if we handle it explicitly.

If `VerifyProofNotRequested` is returned, the txn-sender should not
retry as it can never succeed. This error is not supposed to happen, but
it is better if we handle it explicitly.
@dartdart26 dartdart26 self-assigned this Mar 29, 2026
@dartdart26 dartdart26 requested a review from a team as a code owner March 29, 2026 20:10
@cla-bot cla-bot bot added the cla-signed label Mar 29, 2026
@github-actions
Copy link
Copy Markdown

Changed Lines Coverage

Coverage of added/modified lines: 100.0%

Per-file breakdown

Diff Coverage

Diff: origin/main...HEAD, staged and unstaged changes

  • coprocessor/fhevm-engine/transaction-sender/src/ops/verify_proof.rs (100%)

Summary

  • Total: 3 lines
  • Missing: 0 lines
  • Coverage: 100%

@dartdart26
Copy link
Copy Markdown
Collaborator Author

@Mergifyio queue

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 30, 2026

Merge Queue Status

This pull request spent 2 hours 16 minutes 34 seconds in the queue, including 1 hour 16 minutes 17 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
  • check-success = run-e2e-tests / fhevm-e2e-test
  • any of [🛡 GitHub branch protection]:
    • check-success = common-pull-request/lint (bpr)
    • check-neutral = common-pull-request/lint (bpr)
    • check-skipped = common-pull-request/lint (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-success = coprocessor-cargo-test/cargo-tests (bpr)
    • check-neutral = coprocessor-cargo-test/cargo-tests (bpr)
    • check-skipped = coprocessor-cargo-test/cargo-tests (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-success = coprocessor-dependency-analysis/dependencies-check (bpr)
    • check-neutral = coprocessor-dependency-analysis/dependencies-check (bpr)
    • check-skipped = coprocessor-dependency-analysis/dependencies-check (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-skipped = gateway-contracts-deployment-tests/sc-deploy (bpr)
    • check-neutral = gateway-contracts-deployment-tests/sc-deploy (bpr)
    • check-success = gateway-contracts-deployment-tests/sc-deploy (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-success = kms-connector-tests/test-connector (bpr)
    • check-neutral = kms-connector-tests/test-connector (bpr)
    • check-skipped = kms-connector-tests/test-connector (bpr)

mergify bot added a commit that referenced this pull request Mar 30, 2026
@mergify mergify bot removed the merge-queued label Mar 30, 2026
@mergify mergify bot merged commit cbdd141 into main Mar 30, 2026
82 checks passed
@mergify mergify bot deleted the petar/verify-proof-not-req branch March 30, 2026 14:23
@mergify mergify bot removed the queued label Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants