docs: clarify fromExternal view limitations#2230
Open
ming1523 wants to merge 1 commit intozama-ai:mainfrom
Open
docs: clarify fromExternal view limitations#2230ming1523 wants to merge 1 commit intozama-ai:mainfrom
ming1523 wants to merge 1 commit intozama-ai:mainfrom
Conversation
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @ming1523 on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
Author
|
I have already signed the individual CLA on April 1, 2026. This PR is part of the same small cleanup series as #2226, so I am waiting for the CLA bot/config to be refreshed on this branch as well. |
|
This PR is unverified and has been open for 2 days, it will now be closed. If you want to contribute please sign the CLA as indicated by the bot. |
Contributor
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR documents that functions using
FHE.fromExternal()should not be marked asview.Why
FHE.fromExternal()often looks like a read-only conversion step from a developer's perspective, but in practice it performs proof validation and is not compatible with Solidity'sviewmodifier.Without an explicit note, this can be a confusing DX trap when developers try to write helper functions that feel read-only and then hit compiler errors.
This PR adds that guidance in the main places where developers are introduced to encrypted input handling.
Fixes #2026.
Changes
docs/sdk-guides/input.mddocs/solidity-guides/inputs.mdFHE.fromExternal()Validation
FHE.fromExternal()guidance