Skip to content

fix(coprocessor): avoid useless clone#2321

Open
rudy-6-4 wants to merge 1 commit intomainfrom
rudy/coprocessor/no-useless-clone
Open

fix(coprocessor): avoid useless clone#2321
rudy-6-4 wants to merge 1 commit intomainfrom
rudy/coprocessor/no-useless-clone

Conversation

@rudy-6-4
Copy link
Copy Markdown
Contributor

No description provided.

@rudy-6-4 rudy-6-4 requested review from a team as code owners April 17, 2026 12:31
@cla-bot cla-bot Bot added the cla-signed label Apr 17, 2026
@github-actions
Copy link
Copy Markdown

Coprocessor Changed Lines Coverage

Coverage of added/modified lines in coprocessor: 58.0%

Per-file breakdown

Diff Coverage

Diff: origin/main...HEAD, staged and unstaged changes

  • coprocessor/fhevm-engine/fhevm-engine-common/src/keys.rs (0.0%): Missing lines 88,120,281
  • coprocessor/fhevm-engine/fhevm-engine-common/src/utils.rs (100%)
  • coprocessor/fhevm-engine/gw-listener/src/aws_s3.rs (0.0%): Missing lines 145
  • coprocessor/fhevm-engine/gw-listener/src/gw_listener.rs (100%)
  • coprocessor/fhevm-engine/scheduler/src/dfg/scheduler.rs (100%)
  • coprocessor/fhevm-engine/sns-worker/src/executor.rs (100%)
  • coprocessor/fhevm-engine/sns-worker/src/lib.rs (0.0%): Missing lines 549

Summary

  • Total: 12 lines
  • Missing: 5 lines
  • Coverage: 58%

coprocessor/fhevm-engine/fhevm-engine-common/src/keys.rs

  84         let compact_public_key = CompactPublicKey::new(&client_key);
  85         let crs = CompactPkeCrs::from_config(config, MAX_BITS_TO_PROVE).expect("CRS creation");
  86         let compressed_server_key = CompressedServerKey::new(&client_key);
  87         #[cfg(not(feature = "gpu"))]
! 88         let server_key = compressed_server_key.decompress();
  89         #[cfg(feature = "gpu")]
  90         let server_key = compressed_server_key.clone().decompress();
  91         #[cfg(not(feature = "gpu"))]
  92         let (

  116             #[cfg(not(feature = "gpu"))]
  117             server_key_without_ns,
  118             client_key: Some(client_key),
  119             compact_public_key,
! 120             public_params: Arc::new(crs),
  121             #[cfg(feature = "gpu")]
  122             compressed_server_key: compressed_server_key.clone(),
  123             #[cfg(feature = "gpu")]
  124             #[cfg(feature = "latency")]

  277             safe_deserialize_key(&f.compressed_server_key)
  278                 .expect("deserialize compressed server key");
  279 
  280         FhevmKeys {
! 281             client_key,
  282             compact_public_key: safe_deserialize_key(&f.compact_public_key)
  283                 .expect("deserialize compact public key"),
  284             public_params: Arc::new(
  285                 safe_deserialize_key(&f.public_params).expect("deserialize public params"),

coprocessor/fhevm-engine/gw-listener/src/aws_s3.rs

  141     // e.g BBBBBB.s3.bla.bli.amazonaws.blu, the bucket is part of the domain
  142     let s3_bucket_url = if s3_bucket_url.contains("minio:9000") {
  143         // TODO: replace by docker configuration
  144         warn!(s3_bucket_url, "Using localhost for minio access");
! 145         s3_bucket_url.replace("minio:9000", "172.17.0.1:9000")
  146     } else {
  147         s3_bucket_url.to_owned()
  148     };
  149     let parsed_url_and_bucket = url::Url::parse(&s3_bucket_url)?;

coprocessor/fhevm-engine/sns-worker/src/lib.rs

  545         info!(
  546             interval_secs = interval_secs,
  547             "Starting gauge update routine"
  548         );
! 549         spawn_gauge_update_routine(Duration::from_secs(interval_secs.into()), pg_mngr.pool());
  550     }
  551 
  552     // Spawns a task to handle S3 uploads
  553     spawn(async move {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant