refactor(coprocessor): fix db-migration misconfigs#254
Merged
Conversation
tawadaa
force-pushed
the
aw/chore/fix-rust-base-images
branch
from
bb361e1 to
e9b24bf
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the database migration setup by removing the old fhevm-db Dockerfile and introducing a new multi-stage db-migration Dockerfile, and updates both the Docker Compose service and CI workflow to use the new configuration.
- Remove legacy
fhevm-db/Dockerfileand adddb-migration/Dockerfilewith builder and runtime stages - Update
docker-compose.ymlto reference the new migration image, add startup command and healthcheck - Rename CI job and concurrency group in the GitHub Actions workflow to target
db-migration
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| coprocessor/fhevm-engine/fhevm-db/Dockerfile | Deleted legacy Dockerfile |
| coprocessor/fhevm-engine/db-migration/Dockerfile | Added new multi-stage Dockerfile for migrations |
| coprocessor/fhevm-engine/coprocessor/docker-compose.yml | Switched service to use new Dockerfile, added healthcheck |
| .github/workflows/coprocessor-docker-build-db-migration.yml | Renamed workflow job and concurrency group to db-migration |
tawadaa
force-pushed
the
aw/chore/fix-rust-base-images
branch
from
1c21cee to
26cc0ba
Compare
antoniupop
approved these changes
Jun 12, 2025
tawadaa
force-pushed
the
aw/chore/fix-rust-base-images
branch
3 times, most recently
from
5511665 to
ac65cbe
Compare
tawadaa
force-pushed
the
aw/chore/fix-rust-base-images
branch
from
ac65cbe to
db7fb57
Compare
paulo-zama
pushed a commit
that referenced
this pull request
Mar 26, 2026
By default the simple nonce manager is used. Set cached nonce manager to allow parallel transaction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.