Skip to content

fix(coprocessor): change common-docker template#276

Merged
fegmorte merged 7 commits intomainfrom
fred/ci/change-docker-template
Jun 16, 2025
Merged

fix(coprocessor): change common-docker template#276
fegmorte merged 7 commits intomainfrom
fred/ci/change-docker-template

Conversation

@fegmorte
Copy link
Copy Markdown
Contributor

No description provided.

@tawadaa tawadaa requested review from Copilot and tawadaa June 13, 2025 16:08
Copy link
Copy Markdown
Contributor

@tawadaa tawadaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @fegmorte

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the gw-listener Docker setup by renaming build stages and switching the CI workflow to a new common-docker template with S3 caching support.

  • Renamed the Docker “runtime” stage to “prod” and added an empty “dev” stage alias
  • Updated the GitHub Actions job to use common-docker.yml, added AWS cache secrets, and adjusted permissions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
coprocessor/fhevm-engine/gw-listener/Dockerfile Renamed stage alias from runtime to prod, added dev stage
.github/workflows/coprocessor-docker-build-gw-listener.yml Switched CI template, added AWS cache secrets, updated permissions and inputs
Comments suppressed due to low confidence (5)

.github/workflows/coprocessor-docker-build-gw-listener.yml:54

  • [nitpick] The docker-file path includes a leading ./; ensure the common-docker template resolves this correctly or remove the ./ for consistency with other jobs.
docker-file: "./coprocessor/fhevm-engine/gw-listener/Dockerfile"

.github/workflows/coprocessor-docker-build-gw-listener.yml:45

  • [nitpick] Review whether the pull-requests: 'read' permission is required by the template; granting unused permissions can broaden the attack surface.
pull-requests: 'read'

coprocessor/fhevm-engine/gw-listener/Dockerfile:17

  • You’ve renamed the runtime stage to prod. Please verify that any downstream references (e.g., CI templates or deployment scripts) expecting runtime are updated accordingly to avoid build failures.
FROM cgr.dev/chainguard/glibc-dynamic:latest AS prod

coprocessor/fhevm-engine/gw-listener/Dockerfile:35

  • [nitpick] The new dev stage is empty and simply aliases prod. Consider adding development-specific steps or removing the unused stage to keep the Dockerfile clear.
FROM prod AS dev

.github/workflows/coprocessor-docker-build-gw-listener.yml:40

  • Confirm that the AWS S3 credentials are strictly necessary for this job and scoped with least privilege to minimize risk if they’re leaked.
AWS_ACCESS_KEY_S3_USER: ${{ secrets.AWS_ACCESS_KEY_S3_USER }}

@fegmorte fegmorte force-pushed the fred/ci/change-docker-template branch from a1f2711 to 63f7a0f Compare June 13, 2025 16:46
@fegmorte fegmorte marked this pull request as ready for review June 13, 2025 16:55
@fegmorte fegmorte merged commit e342ee1 into main Jun 16, 2025
62 checks passed
@fegmorte fegmorte deleted the fred/ci/change-docker-template branch June 16, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants