Skip to content

refactor(gateway-contracts): rename GatewayConfig initialization event to InitializeGatewayConfig#281

Merged
isaacdecoded merged 1 commit intomainfrom
isaac/265/refactor/rename-gateway-config-initialization-event
Jun 16, 2025
Merged

refactor(gateway-contracts): rename GatewayConfig initialization event to InitializeGatewayConfig#281
isaacdecoded merged 1 commit intomainfrom
isaac/265/refactor/rename-gateway-config-initialization-event

Conversation

@isaacdecoded
Copy link
Copy Markdown
Contributor

Closes zama-ai/fhevm-internal#72

@isaacdecoded
Copy link
Copy Markdown
Contributor Author

@RomanBredehoft do you think we must sync with the Coprocessor Team about this event renaming or better to ask them directly?

@isaacdecoded isaacdecoded marked this pull request as ready for review June 13, 2025 16:30
@isaacdecoded isaacdecoded requested a review from melanciani June 13, 2025 16:30
Copy link
Copy Markdown
Contributor

@melanciani melanciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great !

@melanciani
Copy link
Copy Markdown
Contributor

@isaacdecoded not sure why coprocessor would need to be updated, are they listening to the init event ?

@isaacdecoded
Copy link
Copy Markdown
Contributor Author

isaacdecoded commented Jun 16, 2025

are they listening to the init event?

That's the actual question haha I'd say not but wanted to confirm with you 👍

@melanciani
Copy link
Copy Markdown
Contributor

you could simply check in the whole fhevm repo if they listen to it, or directly ask @dartdart26 , but I really don't think they are

@isaacdecoded isaacdecoded force-pushed the isaac/265/refactor/rename-gateway-config-initialization-event branch from 68be526 to a01a700 Compare June 16, 2025 15:23
@isaacdecoded isaacdecoded merged commit 93dd60d into main Jun 16, 2025
54 checks passed
@isaacdecoded isaacdecoded deleted the isaac/265/refactor/rename-gateway-config-initialization-event branch June 16, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants