ci(common): rename jobs to make it easier checks requirements#294
Merged
ci(common): rename jobs to make it easier checks requirements#294
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aquint-zama
force-pushed
the
alexq/ci/rename-actions
branch
2 times, most recently
from
b2d55f8 to
2921123
Compare
tawadaa
approved these changes
Jun 16, 2025
Contributor
tawadaa
left a comment
tawadaa
left a comment
There was a problem hiding this comment.
LGTM, thanks @aquint-zama
aquint-zama
force-pushed
the
alexq/ci/rename-actions
branch
from
2921123 to
7e033df
Compare
Comment on lines
+58
to
+62
| needs: build | ||
| name: gateway-contracts-docker-build/docker-hardhat-test (bpr) | ||
| uses: ./.github/workflows/gateway-contracts-hardhat-tests-docker.yml | ||
| with: | ||
| image-name: ${{ needs.docker-gateway-contracts.outputs.image_name }} | ||
| image-name: ${{ needs.build.outputs.image_name }} |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 10 months ago
To fix the issue, we need to add a permissions block to the docker-hardhat-test job. This block should specify the minimal permissions required for the job to function. Based on the context of the workflow, the job likely only needs contents: read to access the repository's contents. If additional permissions are required, they should be explicitly added.
Suggested changeset
1
.github/workflows/gateway-contracts-docker-build.yml
| @@ -59,2 +59,4 @@ | ||
| name: gateway-contracts-docker-build/docker-hardhat-test (bpr) | ||
| permissions: | ||
| contents: read | ||
| uses: ./.github/workflows/gateway-contracts-hardhat-tests-docker.yml |
Copilot is powered by AI and may make mistakes. Always verify output.
aquint-zama
force-pushed
the
alexq/ci/rename-actions
branch
from
7e033df to
38a40bb
Compare
Contributor
Author
|
@tawadaa could you merge it, I can't |
aquint-zama
force-pushed
the
alexq/ci/rename-actions
branch
2 times, most recently
from
03cb30b to
6b38f3c
Compare
Adding a convention that a job name with `(bpr)` will be a branch protection requirement (to make it easier to find them in Github UI)
- remove persist-credentials - fixes job permissions
aquint-zama
force-pushed
the
alexq/ci/rename-actions
branch
from
6b38f3c to
9f161e8
Compare
paulo-zama
pushed a commit
that referenced
this pull request
Mar 26, 2026
* ui enhancements * remove learn nav link * fix typo in dApp button * remove reference to learn icon learn icon removed from nav, so must also remove the reference to the associated icon that is never used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a convention that a job name with
(bpr)will be a branch protection requirement (to make it easier to find them in Github UI)