feat(coprocessor): fhevm-listener, health check#314
Merged
Conversation
7963c21 to
c3d6bf6
Compare
3b337cf to
be780de
Compare
dartdart26
reviewed
Jun 17, 2025
Collaborator
dartdart26
left a comment
There was a problem hiding this comment.
Looks good overall. I added some comments that, I think, are worth considering.
be780de to
bda0953
Compare
fdde187 to
d12f3a1
Compare
d12f3a1 to
5d0e6ab
Compare
5d0e6ab to
d9cb582
Compare
d9cb582 to
970a1b2
Compare
goshawk-3
requested changes
Jun 18, 2025
970a1b2 to
e37d56e
Compare
goshawk-3
approved these changes
Jun 19, 2025
e37d56e to
f930f81
Compare
f930f81 to
d25d316
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a health-check subsystem to the FHEVM listener, exposing liveness and readiness endpoints, and updates integration tests to validate health behavior.
- Added a new
health_checkmodule with HTTP endpoints for/livenessand/healthz. - Integrated
HealthCheckstartup inmainand exposed ahealth_portCLI flag. - Extended integration tests to exercise the new health endpoints.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| coprocessor/fhevm-engine/fhevm-listener/tests/integration_test.rs | Refactored DB URL constant; added test_health for health-check |
| coprocessor/fhevm-engine/fhevm-listener/src/lib.rs | Imported new health_check module |
| coprocessor/fhevm-engine/fhevm-listener/src/health_check.rs | Entire new health-check implementation |
| coprocessor/fhevm-engine/fhevm-listener/src/cmd/mod.rs | Added health_port arg; wired up HealthCheck in CLI handling |
| coprocessor/fhevm-engine/fhevm-listener/Cargo.toml | Added axum, serde_json, tokio-util, tower-http, reqwest |
| coprocessor/fhevm-engine/.cargo/deny.toml | Whitelisted CDLA-Permissive-2.0 license |
Comments suppressed due to low confidence (2)
coprocessor/fhevm-engine/fhevm-listener/src/health_check.rs:60
- [nitpick] The status message
Only connectedis ambiguous; a clearer message likeConnectedorHealth checks passedwould improve readability.
self.message = "Only connected".to_string();
coprocessor/fhevm-engine/fhevm-listener/tests/integration_test.rs:252
- The new health-check test covers only the happy path and node shutdown; consider adding tests for database-connectivity failure and blockchain-connectivity failure to exercise unhealthy branches.
#[tokio::test]
dartdart26
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.