Merged
Conversation
db67dbd to
d80eaf4
Compare
82ef26a to
bb057ba
Compare
rudy-6-4
reviewed
Jun 17, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR refactors scheduling to support multi-GPU environments by replacing single GPU key instances with vectors and adding a new locality field, while also updating CI configurations and benchmark features for latency and throughput.
- Changes data structures and constructors (e.g. in scheduler and keys modules) to use Vectfhe::CudaServerKey instead of a single key.
- Updates scheduling algorithms, benchmark configuration options, and CI workflows to accommodate new GPU scheduling policies and optimization targets.
Reviewed Changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| coprocessor/fhevm-engine/scheduler/src/dfg/scheduler.rs | Updated GPU scheduling logic with a new locality field and changed csks field type to a vector. |
| coprocessor/fhevm-engine/scheduler/src/dfg.rs | Added a locality field to OpNode to support GPU scheduling. |
| coprocessor/fhevm-engine/fhevm-engine-common/src/keys.rs | Updated the GPU key storage to a vector with conditional configuration for latency versus non-latency modes. |
| coprocessor/fhevm-engine/executor/src/server.rs | Modified GPU key handling to index into the vector (using csks[0]) for setting the server key. |
| Various benchmark and CI files | Introduced new features (bench, latency, throughput) and updated workflow inputs for scheduling and optimization target. |
Files not reviewed (2)
- coprocessor/fhevm-engine/coprocessor/.sqlx/query-514d2ee9ff416b42cc48b33df6a2ef5bb25f3ed9abdd2a03957d42252812278a.json: Language not supported
- coprocessor/fhevm-engine/coprocessor/.sqlx/query-9d7dd33f60a053cf0f7e9a480d32ae6aaf684011580f0534afb25e0dd39d50a9.json: Language not supported
Comments suppressed due to low confidence (2)
coprocessor/fhevm-engine/scheduler/src/dfg/scheduler.rs:58
- Ensure that all code paths accessing the csks vector perform a runtime check or handle the case when the vector is empty to avoid potential panics when indexing.
csks: Vec<tfhe::CudaServerKey>,
coprocessor/fhevm-engine/fhevm-engine-common/src/keys.rs:84
- [nitpick] Consider adding inline comments explaining the conditional compilation for 'latency' versus default GPU key decompression so future maintainers can easily understand the rationale behind the different initialization flows.
gpu_server_key: (0..get_number_of_gpus() as u32)
rudy-6-4
approved these changes
Jun 17, 2025
6c96f19 to
9f1b474
Compare
9f1b474 to
16bb9b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.