Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for multiple coprocessors in the FHEVM test suite, enabling the deployment and testing of a distributed coprocessor architecture. It replaces the single coprocessor setup with three separate instances (coprocessor-0, coprocessor-1, and coprocessor-2) for enhanced testing capabilities.
- Splits the single coprocessor configuration into three separate coprocessor instances with unique identifiers
- Updates deployment scripts to handle multiple coprocessor services with individual environment files
- Configures separate S3 buckets and database instances for each coprocessor to avoid conflicts
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| update-kms-keys.sh | Updates KMS key configuration script to handle multiple coprocessor environment files |
| deploy-fhevm-stack.sh | Modifies deployment script to support three separate coprocessor components |
| .env.gateway | Configures gateway to recognize all three coprocessors with unique addresses and S3 buckets |
| .env.coprocessor | Removes the original single coprocessor configuration file |
| minio-docker-compose.yml | Creates separate S3 buckets for each coprocessor instance |
| coprocessor-0-docker-compose.yml | Updates original coprocessor to use indexed naming and resources |
| coprocessor-1-docker-compose.yml | Adds new docker compose configuration for second coprocessor instance |
| coprocessor-2-docker-compose.yml | Adds new docker compose configuration for third coprocessor instance |
leventdem
force-pushed
the
aw/test-suite/coproc-3
branch
2 times, most recently
from
5606bb2 to
3255a71
Compare
tawadaa
force-pushed
the
aw/test-suite/coproc-3
branch
from
d7a7cf2 to
766362d
Compare
leventdem
force-pushed
the
aw/test-suite/coproc-3
branch
2 times, most recently
from
1418590 to
fbe461e
Compare
leventdem
force-pushed
the
aw/test-suite/coproc-3
branch
2 times, most recently
from
4cc32ca to
a90e531
Compare
Extend input proof test to check the numbers of coprocessors which have signed the zkpok verification and added the ciphertext. A specific getter in ciphertext commits contract is called in order to know if each coprocessor has executed an `add ciphertext` transaction. BREAKING CHANGE: adding env variables in test-suite config file New variables: NUMBER_OF_COPROCESSORS=3 CIPHERTEXT_COMMITS_CONTRACT_ADDRESS=0x576Ea67208b146E63C5255d0f90104E25e3e04c7 GATEWAY_NODE_URL=http://fhevm-gateway-node:8546
tawadaa
force-pushed
the
aw/test-suite/coproc-3
branch
from
a10d5bd to
c578000
Compare
leventdem
force-pushed
the
aw/test-suite/coproc-3
branch
from
72063ea to
f926af3
Compare
Contributor
|
duplicate of #1959 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This is for testing multiple coprocessors, shouldn't be merged as it is, need more work to choose how many coprocessor when running
fhevm-cli deploy