feat(kms-connector): keygen/crsgen#813
Closed
eudelins-zama wants to merge 2 commits intofeat/keygen_via_gatewayfrom
Closed
feat(kms-connector): keygen/crsgen#813eudelins-zama wants to merge 2 commits intofeat/keygen_via_gatewayfrom
eudelins-zama wants to merge 2 commits intofeat/keygen_via_gatewayfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements keygen/crsgen functionality for the KMS connector, adding support for key generation and common reference string generation operations. The implementation includes request/response handling, database schema updates, and comprehensive test coverage.
Reviewed Changes
Copilot reviewed 31 out of 51 changed files in this pull request and generated no comments.
Show a summary per file
- Adds PrepKeygen, Keygen, and Crsgen request/response types and processing
- Updates database schema with new tables and custom types for key management operations
- Extends GRPC client to handle key management operations with proper timeout and retry logic
| File | Description |
|---|---|
| kms-connector/simple-connector/Cargo.toml | Updates TFHE dependency version |
| kms-connector/crates/utils/src/types/mod.rs | Exports new response types |
| kms-connector/crates/utils/src/types/kms_response.rs | Implements new KMS response types and processing |
| kms-connector/crates/utils/src/types/gw_event.rs | Updates gateway events for new key management operations |
| kms-connector/crates/utils/src/types/grpc.rs | Adds GRPC request/response types |
| kms-connector/crates/utils/src/types/db.rs | Defines database types for key management |
| kms-connector/crates/tx-sender/tests/*.rs | Test updates for new response types |
| kms-connector/crates/tx-sender/src/core/*.rs | Transaction sender updates for key management |
| kms-connector/crates/kms-worker/tests/*.rs | Worker test updates |
| kms-connector/crates/kms-worker/src/core/*.rs | Worker implementation for key management |
| kms-connector/crates/gw-listener/tests/*.rs | Gateway listener test updates |
| kms-connector/crates/gw-listener/src/core/*.rs | Gateway listener updates |
| kms-connector/connector-db/migrations/*.sql | Database migration for new schema |
| kms-connector/config/kms-worker.toml | Configuration updates |
| kms-connector/Cargo.toml | Dependency updates |
Files not reviewed (19)
- kms-connector/.sqlx/query-11bc16cf6cb7efa9e2753b8c0f4dfc672fe3053386c2920dfd7c80f1676d60e5.json: Language not supported
- kms-connector/.sqlx/query-1c2b538261f7976411e66d51f77f24a053d62c95cff95e753669d549a2f7b8bf.json: Language not supported
- kms-connector/.sqlx/query-1e807030cd81f561d8115a77024ba5e53271357f5887cd327676092a30a3dee7.json: Language not supported
- kms-connector/.sqlx/query-39c059ee786b91cdda4288eecc1af69b8166dc79e4754ca74ee373c1cfaa5066.json: Language not supported
- kms-connector/.sqlx/query-4d8fef33610f8baf96a2da80dec76e23423aa66331b1315c5c74a06d8a4af120.json: Language not supported
- kms-connector/.sqlx/query-5d0b62324d38394bc77e5a12024b0875102ee676ca73bfcacaf0945ed3d10d51.json: Language not supported
- kms-connector/.sqlx/query-69196b39e59fe6f9e449f7cd1f30fe6117c9670d56a08f64e49e3d9a7b109fb9.json: Language not supported
- kms-connector/.sqlx/query-794195f509f409f4facd8e95540593d0498702193518834022c34ea56e79e060.json: Language not supported
- kms-connector/.sqlx/query-7f74ef6dec3a6111b0f0e31c74caf0d93877520081dd428c8bebc167a4e87104.json: Language not supported
- kms-connector/.sqlx/query-8bda4e7874544b90727a06bc0132103aa66498cf41ca10a4352ce74e079eb9bc.json: Language not supported
- kms-connector/.sqlx/query-976df9ddb90a8496ff6392dce98caffef797e8177193bf4711fafa1aab746040.json: Language not supported
- kms-connector/.sqlx/query-9bc90c989ac36a54a369c2e4992b633948b7a114df7d4726034894ae4dd5cdcc.json: Language not supported
- kms-connector/.sqlx/query-ae80f83b6a6f16cd77a8e1a8a177ca8631cf6a17fc91e6f6784d160ceedfcb98.json: Language not supported
- kms-connector/.sqlx/query-b6d8f88d1d7767f83b99a4169b777b0655183d155e508189a7b9703e9b343e81.json: Language not supported
- kms-connector/.sqlx/query-e1dcc890ca2f261e88d804e3ba9982a45915fd578fda8e74986aaf7cbd560310.json: Language not supported
- kms-connector/.sqlx/query-eb4c0459deb269abd66cd57bba8174a4548b7cba727730db8938be880f9bb748.json: Language not supported
- kms-connector/.sqlx/query-ee7370edf3dd22bde6e35ecc06e67e0603aca78d68923c4c638f369f95406cb4.json: Language not supported
- kms-connector/.sqlx/query-f8a2566ed6b032aed630dc06870f844fa7b2a7e1531c9112f43d59388400cb99.json: Language not supported
- kms-connector/.sqlx/query-fb044e1f8fc652401b00b59ef041debded52e491cf85e3c23e660dd2af5380aa.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
eudelins-zama
force-pushed
the
simon/feat/85/connector-keygen
branch
2 times, most recently
from
7124aea to
243be77
Compare
eudelins-zama
force-pushed
the
simon/feat/85/connector-keygen
branch
2 times, most recently
from
3d2b991 to
c46894e
Compare
eudelins-zama
force-pushed
the
simon/feat/85/connector-keygen
branch
from
66c34e8 to
6e7245c
Compare
isaacdecoded
force-pushed
the
feat/keygen_via_gateway
branch
from
1160d00 to
801d1f7
Compare
* feat(gateway-contracts): implement single keygen * test(gateway-contracts): fix KmsManagement tests and few contract logic * fix(gateway-contracts): adjust Decryption event param names and fix mock tests/contracts * chore(gateway-contracts): rollback to keygen method name * feat(gateway-contracts): introduce keygen threshold and clean KmsManagement from deprecated vars * refactor(gateway-contracts): rename KmsManagement contract to KMSManagement * chore(gateway-contracts): update bindings and mocks * chore(gateway-contracts): execute git mv for case-sensitiveness * chore(gateway-contracts): execute git mv for case-sensitiveness * fix(gateway-contracts): include missed keygen threshold parameter on upgrade * refactor(gateway-contracts): rename task file for FHE keys gen --------- Co-authored-by: Isaac Herrera <isaac.herrera@zama.ai>
eudelins-zama
force-pushed
the
feat/keygen_via_gateway
branch
from
801d1f7 to
c269808
Compare
eudelins-zama
force-pushed
the
simon/feat/85/connector-keygen
branch
from
6e7245c to
f0e17c1
Compare
isaacdecoded
force-pushed
the
feat/keygen_via_gateway
branch
from
c4bc347 to
cdcecd9
Compare
chore(kms-connector): update keygen events chore(kms-connector): handle prep keygen chore(kms-connector): handle keygen draft chore(kms-connector): update keygen bindings chore(kms-connector): add crsgen draft chore(kms-connector): kms management contract renaming fix(kms-connector): fix keytype parsing fix(kms-connector): fix keygen test chore(kms-connector): update kms_grcp + config
eudelins-zama
force-pushed
the
simon/feat/85/connector-keygen
branch
from
06603be to
93d8df1
Compare
Contributor
Author
|
Closing the PR because there's too many conflict not related to my code. What I did instead: I squashed all my commit into a single one, and opened this new PR that was created from the updated feature branch, and cherry-picked this commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref https://github.com/zama-ai/fhevm-internal/issues/85