fix(kms-connector): poll KMS response if request already exists#856
Merged
eudelins-zama merged 1 commit intomainfrom Sep 24, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes KMS connector error handling to properly handle cases where a KMS request already exists. Instead of treating AlreadyExists errors as recoverable and retrying, the code now recognizes this as a successful condition and proceeds to poll for the response.
- Updates error classification to treat
AlreadyExistsas recoverable for requests but not for responses - Modifies retry logic to immediately return success when encountering
AlreadyExistsstatus - Removes
NotFoundfrom recoverable response errors as it's no longer needed
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| processor.rs | Updates error classification logic for request and response status codes |
| kms_client.rs | Modifies retry loop to handle AlreadyExists as immediate success case |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
c76f7ac to
c157b28
Compare
c157b28 to
5494850
Compare
rudy-6-4
pushed a commit
that referenced
this pull request
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/zama-ai/fhevm-internal/issues/418