Skip to content

fix(coprocessor): Add retry logic for DB connections within zkproof computation tasks #429#874

Merged
goshawk-3 merged 4 commits intomainfrom
georgi/zkproof-worker/use-pg-pool
Sep 23, 2025
Merged

fix(coprocessor): Add retry logic for DB connections within zkproof computation tasks #429#874
goshawk-3 merged 4 commits intomainfrom
georgi/zkproof-worker/use-pg-pool

Conversation

@goshawk-3
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds retry logic for database connections within zkproof computation tasks to improve resilience against transient database connection failures.

  • Replaces direct PgPool usage with PostgresPoolManager for automatic retry capabilities
  • Updates the ZkProofService to use the new pool manager with proper cancellation handling
  • Refactors worker spawning to leverage database retry mechanisms through the pool manager

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
coprocessor/fhevm-engine/zkproof-worker/src/verifier.rs Core implementation changes replacing PgPool with PostgresPoolManager and adding retry logic
coprocessor/fhevm-engine/zkproof-worker/src/tests/utils.rs Updates test setup to use PostgresPoolManager instead of direct PgPool
coprocessor/fhevm-engine/zkproof-worker/src/tests/mod.rs Updates test methods to extract PgPool from PostgresPoolManager
coprocessor/fhevm-engine/zkproof-worker/src/lib.rs Adds configuration fields and error conversion for ServiceError
coprocessor/fhevm-engine/zkproof-worker/Cargo.toml Adds humantime dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@goshawk-3
Copy link
Copy Markdown
Contributor Author

@Mergifyio queue

@mergify
Copy link
Copy Markdown

mergify bot commented Sep 18, 2025

queue

🛑 The pull request has been removed from the queue main

Details

The draft pull request cannot be created.

You can take a look at Queue: Embarked in merge queue check runs for more details about the failure.

@goshawk-3 goshawk-3 marked this pull request as ready for review September 19, 2025 04:35
@goshawk-3
Copy link
Copy Markdown
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Copy Markdown

mergify bot commented Sep 19, 2025

refresh

✅ Pull request refreshed

@goshawk-3 goshawk-3 force-pushed the georgi/zkproof-worker/use-pg-pool branch from ecec5c7 to ab7966f Compare September 22, 2025 13:03
@goshawk-3
Copy link
Copy Markdown
Contributor Author

@Mergifyio queue

@mergify
Copy link
Copy Markdown

mergify bot commented Sep 22, 2025

queue

🛑 The pull request has been removed from the queue main

Details

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details about the failure.

@mergify
Copy link
Copy Markdown

mergify bot commented Sep 22, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@goshawk-3 goshawk-3 force-pushed the georgi/zkproof-worker/use-pg-pool branch from ab7966f to 63547cd Compare September 23, 2025 09:24
@goshawk-3 goshawk-3 merged commit aa8ec89 into main Sep 23, 2025
148 checks passed
@goshawk-3 goshawk-3 deleted the georgi/zkproof-worker/use-pg-pool branch September 23, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants