Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds retry logic for database connections within zkproof computation tasks to improve resilience against transient database connection failures.
- Replaces direct PgPool usage with PostgresPoolManager for automatic retry capabilities
- Updates the ZkProofService to use the new pool manager with proper cancellation handling
- Refactors worker spawning to leverage database retry mechanisms through the pool manager
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| coprocessor/fhevm-engine/zkproof-worker/src/verifier.rs | Core implementation changes replacing PgPool with PostgresPoolManager and adding retry logic |
| coprocessor/fhevm-engine/zkproof-worker/src/tests/utils.rs | Updates test setup to use PostgresPoolManager instead of direct PgPool |
| coprocessor/fhevm-engine/zkproof-worker/src/tests/mod.rs | Updates test methods to extract PgPool from PostgresPoolManager |
| coprocessor/fhevm-engine/zkproof-worker/src/lib.rs | Adds configuration fields and error conversion for ServiceError |
| coprocessor/fhevm-engine/zkproof-worker/Cargo.toml | Adds humantime dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
|
@Mergifyio refresh |
✅ Pull request refreshed |
ecec5c7 to
ab7966f
Compare
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks:
You may have to fix your CI before adding the pull request to the queue again. |
… computation tasks
ab7966f to
63547cd
Compare
fixes https://github.com/zama-ai/fhevm-internal/issues/429