Skip to content

chore(kms-connector): use eth_sendRawTransactionSync#886

Merged
eudelins-zama merged 7 commits intomainfrom
simon/chore/433/tx-sender-eip-7966
Sep 26, 2025
Merged

chore(kms-connector): use eth_sendRawTransactionSync#886
eudelins-zama merged 7 commits intomainfrom
simon/chore/433/tx-sender-eip-7966

Conversation

@eudelins-zama
Copy link
Copy Markdown
Contributor

@eudelins-zama eudelins-zama commented Sep 24, 2025

@cla-bot cla-bot bot added the cla-signed label Sep 24, 2025
@eudelins-zama eudelins-zama force-pushed the simon/chore/433/tx-sender-eip-7966 branch 3 times, most recently from 909b4d4 to 6d8c5a5 Compare September 25, 2025 11:41
@eudelins-zama eudelins-zama marked this pull request as ready for review September 25, 2025 12:05
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the KMS connector to use the synchronous eth_sendRawTransactionSync method instead of the asynchronous transaction sending approach. This change aims to improve transaction handling reliability and simplify the codebase by removing the need for separate transaction sending and receipt polling operations.

  • Updates transaction sender implementation to use synchronous transaction sending
  • Upgrades Foundry version from v1.2.3 to v1.3.5 across all components
  • Adjusts test timeouts and fixes sequential transaction handling in tests

Reviewed Changes

Copilot reviewed 11 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test-suite/fhevm/fhevm-cli Updates component versions to latest commit hashes and new test suite version
test-suite/fhevm/docker-compose/host-docker-compose.yml Upgrades Foundry image to v1.3.5
test-suite/fhevm/docker-compose/gateway-docker-compose.yml Upgrades Foundry image to v1.3.5
test-suite/e2e/test/gatewayDecrypt/testAsyncDecrypt.ts Changes from parallel to sequential transaction sending for better control
kms-connector/crates/utils/src/tests/setup/gw.rs Updates Anvil image version to v1.3.5
kms-connector/crates/tx-sender/tests/health.rs Increases test timeout from 120s to 300s
kms-connector/crates/tx-sender/tests/data/tx_out_of_gas/2_send_tx.json Removes old transaction hash data file
kms-connector/crates/tx-sender/src/core/tx_sender.rs Core implementation changes to use synchronous transaction sending
kms-connector/crates/tx-sender/Cargo.toml Adds provider-anvil-api feature to alloy dependency
kms-connector/crates/kms-worker/tests/health.rs Increases test timeout from 180s to 300s
kms-connector/crates/gw-listener/tests/health.rs Increases test timeout from 120s to 300s

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Copy Markdown
Collaborator

@dartdart26 dartdart26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good code-wise!

I only have one question. Do we know for a fact that using AnvilApi is safe for production use?

@eudelins-zama eudelins-zama force-pushed the simon/chore/433/tx-sender-eip-7966 branch from a77e580 to f858e28 Compare September 26, 2025 08:33
@eudelins-zama eudelins-zama merged commit 20b204a into main Sep 26, 2025
124 checks passed
@eudelins-zama eudelins-zama deleted the simon/chore/433/tx-sender-eip-7966 branch September 26, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants