chore(kms-connector): use eth_sendRawTransactionSync#886
Merged
eudelins-zama merged 7 commits intomainfrom Sep 26, 2025
Merged
Conversation
909b4d4 to
6d8c5a5
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the KMS connector to use the synchronous eth_sendRawTransactionSync method instead of the asynchronous transaction sending approach. This change aims to improve transaction handling reliability and simplify the codebase by removing the need for separate transaction sending and receipt polling operations.
- Updates transaction sender implementation to use synchronous transaction sending
- Upgrades Foundry version from v1.2.3 to v1.3.5 across all components
- Adjusts test timeouts and fixes sequential transaction handling in tests
Reviewed Changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test-suite/fhevm/fhevm-cli | Updates component versions to latest commit hashes and new test suite version |
| test-suite/fhevm/docker-compose/host-docker-compose.yml | Upgrades Foundry image to v1.3.5 |
| test-suite/fhevm/docker-compose/gateway-docker-compose.yml | Upgrades Foundry image to v1.3.5 |
| test-suite/e2e/test/gatewayDecrypt/testAsyncDecrypt.ts | Changes from parallel to sequential transaction sending for better control |
| kms-connector/crates/utils/src/tests/setup/gw.rs | Updates Anvil image version to v1.3.5 |
| kms-connector/crates/tx-sender/tests/health.rs | Increases test timeout from 120s to 300s |
| kms-connector/crates/tx-sender/tests/data/tx_out_of_gas/2_send_tx.json | Removes old transaction hash data file |
| kms-connector/crates/tx-sender/src/core/tx_sender.rs | Core implementation changes to use synchronous transaction sending |
| kms-connector/crates/tx-sender/Cargo.toml | Adds provider-anvil-api feature to alloy dependency |
| kms-connector/crates/kms-worker/tests/health.rs | Increases test timeout from 180s to 300s |
| kms-connector/crates/gw-listener/tests/health.rs | Increases test timeout from 120s to 300s |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dartdart26
reviewed
Sep 26, 2025
Collaborator
dartdart26
left a comment
There was a problem hiding this comment.
Looks good code-wise!
I only have one question. Do we know for a fact that using AnvilApi is safe for production use?
a77e580 to
f858e28
Compare
dartdart26
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/zama-ai/fhevm-internal/issues/433