chore: slow test refactoring findings#459
Draft
dvdplm wants to merge 6 commits intodvdplm/chore/dedup-crates-tonicfrom
Draft
chore: slow test refactoring findings#459dvdplm wants to merge 6 commits intodvdplm/chore/dedup-crates-tonicfrom
dvdplm wants to merge 6 commits intodvdplm/chore/dedup-crates-tonicfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigating a slow test I found a few things, collected in this PR.
Unclear if we want to merge this as is. Four classes of changes:
Based on #451 (which in turn is based on #440, which is based on #434), hence the draft status.
So, for reviewers:
println!s, demote manyINFOs toDEBUGorTRACEetc?TimingLayergenerally useful or can we do better? Or is it not useful enough?