Avoid double allocating while hashing&serializing#496
Draft
Conversation
…hash as it writes.
…e_serialize_hash_element_versioned`.
Consolidated Tests Results 2026-03-31 - 17:13:27Test ResultsDetails
test-reporter: Run #1110
🎉 All tests passed!TestsView All Tests
🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid the serialize-then-hash pattern by adding a
HashingWriterthat implsstd::io::Writer. Now we can avoid passing aVecbuffer tosafe_serializeand then hash thatVec; instead theHashingWriterhashes as it goes and finalizes in the end.The performance impact is very minor, sadly, most likely because serialization still allocates a bunch. On my system I see memory consumption for one big test go down from ~9Gb to ~8Gb, so not useless I guess.
WIP because it's worth checking other call sites for the "serialize-then-hash" pattern.