Merged
Conversation
Consolidated Tests Results 2026-04-02 - 21:49:14Test Results
Details
test-reporter: Run #3739
🎉 All tests passed!TestsView All Tests
🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
dd23
reviewed
Apr 1, 2026
dd23
reviewed
Apr 1, 2026
dd23
reviewed
Apr 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the workspace to Rust 2024 edition and applies the mechanical migration changes needed across the KMS codebase (keyword collisions like gen, match ergonomics, if let chains, rustfmt/import order changes, and new unsafe requirements such as std::env::set_var).
Changes:
- Bump workspace edition to Rust 2024.
- Apply Rust 2024 migration edits across crates (e.g.,
rng.r#gen(),if let ... && ..., match ergonomics, onegenfield rename). - Reformat/rustfmt and import reordering across many modules; introduce
unsafewrappers for environment variable mutation.
Reviewed changes
Copilot reviewed 291 out of 299 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/kms-health-check/src/config.rs | Import reordering for Rust 2024/rustfmt. |
| observability/src/metrics.rs | Import reordering for Rust 2024/rustfmt. |
| observability/src/grpc.rs | Import reordering for Rust 2024/rustfmt. |
| observability/src/conf.rs | Uses Rust 2024 if let ... && ... chain to flatten validation logic. |
| core/threshold/tests/integration_redis.rs | Import reordering + rustfmt changes in assertions. |
| core/threshold/src/tls_certs.rs | Formatting/import cleanup; tuple-field access spacing normalized. |
| core/threshold/src/malicious_moby.rs | Minor control-flow refactor to return match expression directly. |
| core/threshold/src/grpc/server.rs | Import reordering for Rust 2024/rustfmt. |
| core/threshold/src/choreography/choreographer.rs | Import reordering for Rust 2024/rustfmt. |
| core/threshold/src/bin/non-threshold/kat.rs | Import ordering changes for rustfmt. |
| core/threshold/src/bin/moby/mobygo.rs | Import ordering + rustfmt; match arm formatting; println formatting. |
| core/threshold/src/bin/benches/gen-experiment.rs | Import reordering for Rust 2024/rustfmt. |
| core/threshold/examples/distributed_decryption.rs | Switch .gen() to r#gen() for Rust 2024 keyword; import ordering. |
| core/threshold/benches/prep.rs | Import reordering for Rust 2024/rustfmt. |
| core/threshold/benches/non-threshold/utilities.rs | Import ordering + rustfmt. |
| core/threshold/benches/non-threshold/tfhe-rs/speed/erc20.rs | Switch .gen() to r#gen(); import ordering. |
| core/threshold/benches/non-threshold/tfhe-rs/speed/basic_ops.rs | Switch .gen() to r#gen(); import ordering. |
| core/threshold/benches/non-threshold/tfhe-rs/memory/keygen.rs | Import ordering for rustfmt. |
| core/threshold/benches/non-threshold/tfhe-rs/memory/erc20.rs | Switch .gen() to r#gen(); remove ref mut pattern; import ordering. |
| core/threshold/benches/non-threshold/tfhe-rs/memory/basic_ops.rs | Switch .gen() to r#gen(); import ordering. |
| core/threshold/benches/ceremony.rs | Import ordering for rustfmt. |
| core/threshold/benches/bit_dec.rs | Import ordering for rustfmt. |
| core/threshold/benches/bench_switch_and_squash.rs | Import ordering for rustfmt. |
| core/threshold/benches/bench_prss.rs | Import ordering for rustfmt. |
| core/threshold-types/src/session_id.rs | Import ordering for rustfmt. |
| core/threshold-networking/src/sending_service.rs | Import ordering + rustfmt line wrapping in logs. |
| core/threshold-networking/src/local.rs | Import ordering + rustfmt for assertions. |
| core/threshold-networking/src/health_check.rs | Import ordering for rustfmt. |
| core/threshold-hashing/src/lib.rs | Import ordering for rustfmt. |
| core/threshold-experimental/src/gen_bits_odd.rs | Import ordering for rustfmt. |
| core/threshold-experimental/src/choreography/grpc.rs | Import ordering + tracing import ordering. |
| core/threshold-experimental/src/choreography/choreographer.rs | Import ordering for rustfmt. |
| core/threshold-experimental/src/bin/stairwayctl.rs | Import ordering + rustfmt (println formatting). |
| core/threshold-experimental/src/bgv/utils.rs | Import ordering for rustfmt. |
| core/threshold-experimental/src/bgv/endpoints.rs | Import ordering for rustfmt. |
| core/threshold-experimental/src/bgv/dkg.rs | Import ordering + rustfmt in tests. |
| core/threshold-experimental/src/bgv/dkg_preproc.rs | Import ordering for rustfmt. |
| core/threshold-experimental/src/bgv/dkg_orchestrator.rs | Import ordering for rustfmt. |
| core/threshold-experimental/src/bgv/ddec.rs | Import ordering for rustfmt. |
| core/threshold-experimental/src/bgv/basics.rs | Import ordering + whitespace cleanup. |
| core/threshold-experimental/src/algebra/integers.rs | Minor formatting change + import ordering. |
| core/threshold-experimental/src/algebra/cyclotomic.rs | Import ordering for rustfmt. |
| core/threshold-experimental/benches/non-threshold/utilities.rs | Import ordering for rustfmt. |
| core/threshold-experimental/benches/decoding.rs | Import ordering for rustfmt. |
| core/threshold-experimental/benches/bgv.rs | Import ordering for rustfmt. |
| core/threshold-experimental/benches/algebra.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/tfhe_internals/utils.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/tfhe_internals/switch_and_squash.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/tfhe_internals/raw_parameters.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/tfhe_internals/randomness.rs | Rename gen field to generator; update call sites; iterator mapping rename. |
| core/threshold-execution/src/tfhe_internals/public_keysets.rs | Import ordering for rustfmt; explicit EncryptionKeyChoice import. |
| core/threshold-execution/src/tfhe_internals/parameters.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/tfhe_internals/modulus_switch_noise_reduction_key_generation.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/tfhe_internals/lwe_packing_keyswitch_key.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/tfhe_internals/lwe_keyswitch_key.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/tfhe_internals/lwe_keyswitch_key_generation.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/tfhe_internals/lwe_key.rs | Import ordering + updated MPCMaskRandomGenerator field rename usage. |
| core/threshold-execution/src/tfhe_internals/lwe_ciphertext.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/tfhe_internals/lwe_bootstrap_key.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/tfhe_internals/glwe_key.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/tfhe_internals/glwe_ciphertext.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/tfhe_internals/ggsw_ciphertext.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/tfhe_internals/compression_decompression_key.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/tfhe_internals/compression_decompression_key_generation.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/tests/test_data_setup.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/tests/helper.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/small_execution/prf.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/small_execution/offline.rs | Formatting + Rust 2024 if let ... && ... chain simplification. |
| core/threshold-execution/src/sharing/open.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/sharing/input.rs | Formatting fix for error return parentheses. |
| core/threshold-execution/src/runtime/test_runtime.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/runtime/sessions/small_session.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/runtime/sessions/session_parameters.rs | Assertion formatting (rustfmt). |
| core/threshold-execution/src/random.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/online/triple.rs | Import ordering + r#gen changes in tests via type ordering. |
| core/threshold-execution/src/online/secret_distributions.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/online/preprocessing/redis/noiseflood.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/online/preprocessing/redis/mod.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/online/preprocessing/redis/dkg.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/online/preprocessing/orchestration/producers/triples_producer.rs | Import ordering + multiline error formatting. |
| core/threshold-execution/src/online/preprocessing/orchestration/producers/randoms_producer.rs | Import ordering + multiline error formatting. |
| core/threshold-execution/src/online/preprocessing/orchestration/producers/common.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/online/preprocessing/orchestration/producers/bits_producer.rs | Import ordering + multiline error formatting. |
| core/threshold-execution/src/online/preprocessing/orchestration/dkg_orchestrator.rs | Import ordering + tracing import ordering. |
| core/threshold-execution/src/online/preprocessing/orchestration/consumers/triples_aggregator.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/online/preprocessing/orchestration/consumers/randoms_aggregator.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/online/preprocessing/orchestration/consumers/dkg_bits_processor.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/online/preprocessing/orchestration/consumers/bits_aggregator.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/online/preprocessing/mod.rs | Import ordering + signature formatting for factory function. |
| core/threshold-execution/src/online/preprocessing/memory/mod.rs | Import ordering + signature formatting for factory function. |
| core/threshold-execution/src/online/preprocessing/memory/bit_lift.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/online/preprocessing/dummy.rs | Import ordering + generic impl formatting. |
| core/threshold-execution/src/online/gen_bits.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/online/bit_manipulation.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/online/bit_lift.rs | Import ordering + test import ordering. |
| core/threshold-execution/src/network_value.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/malicious_execution/online/malicious_bit_lift.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/malicious_execution/large_execution/malicious_vss.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/malicious_execution/large_execution/malicious_share_dispute.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/malicious_execution/large_execution/malicious_offline.rs | Generic impl formatting + closure simplification. |
| core/threshold-execution/src/malicious_execution/large_execution/malicious_local_single_share.rs | Error formatting (rustfmt). |
| core/threshold-execution/src/malicious_execution/large_execution/malicious_local_double_share.rs | Error formatting (rustfmt). |
| core/threshold-execution/src/malicious_execution/communication/malicious_broadcast.rs | Formatting fix for error return parentheses. |
| core/threshold-execution/src/large_execution/vss.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/large_execution/single_sharing.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/large_execution/offline.rs | Import ordering + generic impl formatting. |
| core/threshold-execution/src/large_execution/local_single_share.rs | Log formatting (rustfmt). |
| core/threshold-execution/src/large_execution/local_double_share.rs | Uses Rust 2024 if let ... && ... chain simplification. |
| core/threshold-execution/src/large_execution/double_sharing.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/large_execution/coinflip.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/endpoints/reshare_sk.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/endpoints/reconstruct.rs | Formatting fix for error return parentheses. |
| core/threshold-execution/src/endpoints/decryption.rs | Import ordering for rustfmt. |
| core/threshold-execution/src/communication/broadcast.rs | Import ordering for rustfmt. |
| core/threshold-algebra/src/syndrome.rs | Test import ordering (cfg-gated). |
| core/threshold-algebra/src/sharing/shamir.rs | Error formatting (multiline) + import ordering. |
| core/threshold-algebra/src/randomness_check.rs | Import ordering for rustfmt. |
| core/threshold-algebra/src/poly.rs | Error formatting (multiline) for clearer rustfmt layout. |
| core/threshold-algebra/src/galois_rings/utils.rs | Import ordering for rustfmt. |
| core/threshold-algebra/src/galois_rings/degree_8.rs | Import ordering + .gen() to r#gen() in tests; panic formatting. |
| core/threshold-algebra/src/galois_rings/degree_7.rs | Import ordering + .gen() to r#gen() in tests; panic formatting. |
| core/threshold-algebra/src/galois_rings/degree_5.rs | Import ordering + .gen() to r#gen() in tests; panic formatting. |
| core/threshold-algebra/src/galois_rings/degree_3.rs | Import ordering + .gen() to r#gen() in tests; panic formatting. |
| core/threshold-algebra/src/galois_rings/common.rs | Import ordering + small iterator closure simplification; panic formatting. |
| core/threshold-algebra/src/galois_fields/gf8.rs | Import ordering for rustfmt. |
| core/threshold-algebra/src/galois_fields/gf64.rs | Import ordering for rustfmt. |
| core/threshold-algebra/src/galois_fields/gf32.rs | Import ordering for rustfmt. |
| core/threshold-algebra/src/galois_fields/gf256.rs | Import ordering for rustfmt. |
| core/threshold-algebra/src/galois_fields/gf16.rs | Import ordering for rustfmt. |
| core/threshold-algebra/src/galois_fields/gf128.rs | Import ordering for rustfmt. |
| core/threshold-algebra/src/error_correction.rs | Import ordering for rustfmt; test import ordering (cfg-gated). |
| core/threshold-algebra/src/commitment.rs | Import ordering for rustfmt. |
| core/threshold-algebra/src/bivariate.rs | Error formatting (multiline) for clarity. |
| core/threshold-algebra/src/base_ring.rs | Switch rng.gen() to rng.r#gen() due to gen keyword in Rust 2024. |
| core/thread-handles/tests/tests.rs | Import ordering for rustfmt. |
| core/test-utils/src/lib.rs | Import ordering for rustfmt. |
| core/service/tests/common.rs | Import ordering for rustfmt. |
| core/service/tests/backward_compatibility_threshold_fhe.rs | Import ordering for rustfmt. |
| core/service/tests/backward_compatibility_kms_grpc.rs | Import ordering for rustfmt. |
| core/service/test-utils-service/src/lib.rs | Mark std::env::set_var calls unsafe for Rust 2024 (test macros). |
| core/service/src/vault/storage/s3.rs | Import ordering for rustfmt. |
| core/service/src/vault/storage/ram.rs | Rust 2024 if let ... && ... chain simplification; formatting fixes. |
| core/service/src/vault/storage/mod.rs | Import ordering + test assertion formatting. |
| core/service/src/vault/storage/crypto_material/utils.rs | Import ordering + log formatting. |
| core/service/src/vault/storage/crypto_material/traits.rs | Import ordering for rustfmt. |
| core/service/src/vault/storage/crypto_material/threshold.rs | Import ordering + log formatting. |
| core/service/src/vault/storage/crypto_material/tests.rs | Import ordering for rustfmt. |
| core/service/src/vault/storage/crypto_material/readers/wrapped_key.rs | Import ordering for rustfmt. |
| core/service/src/vault/storage/crypto_material/readers/threshold_keys.rs | Import ordering for rustfmt. |
| core/service/src/vault/storage/crypto_material/readers/server_key.rs | Import ordering for rustfmt. |
| core/service/src/vault/storage/crypto_material/readers/fhe_keys.rs | Import ordering for rustfmt. |
| core/service/src/vault/storage/crypto_material/readers/crs.rs | Import ordering for rustfmt. |
| core/service/src/vault/storage/crypto_material/readers/context.rs | Import ordering for rustfmt. |
| core/service/src/vault/storage/crypto_material/centralized.rs | Import ordering for rustfmt. |
| core/service/src/vault/keychain/secretsharing.rs | Import ordering + assertion formatting. |
| core/service/src/vault/keychain/mod.rs | Match ergonomics change (ref removal) + import ordering. |
| core/service/src/vault/aws.rs | Import ordering for rustfmt. |
| core/service/src/util/retry.rs | Macro formatting compressed (rustfmt). |
| core/service/src/util/key_setup/mod.rs | Import ordering + log formatting. |
| core/service/src/util/file_handling.rs | Import ordering for rustfmt. |
| core/service/src/testing/setup/threshold.rs | Import ordering for rustfmt. |
| core/service/src/testing/setup/centralized.rs | Import ordering for rustfmt. |
| core/service/src/testing/mod.rs | Import ordering for rustfmt. |
| core/service/src/testing/helpers.rs | Import ordering for rustfmt. |
| core/service/src/grpc/tests/unit_tests.rs | Assertion formatting (rustfmt). |
| core/service/src/grpc/metastore_status_service.rs | Import ordering + log formatting. |
| core/service/src/engine/utils.rs | Import ordering + log formatting. |
| core/service/src/engine/traits.rs | Import ordering for rustfmt. |
| core/service/src/engine/server.rs | Import ordering for rustfmt. |
| core/service/src/engine/keyset_configuration.rs | Import ordering for rustfmt. |
| core/service/src/engine/context.rs | Import ordering + assertion formatting. |
| core/service/src/engine/centralized/service/preprocessing.rs | Import ordering for rustfmt. |
| core/service/src/engine/centralized/service/mod.rs | Import ordering for rustfmt. |
| core/service/src/engine/centralized/service/key_gen.rs | Import ordering for rustfmt. |
| core/service/src/engine/centralized/service/decryption.rs | Import ordering for rustfmt. |
| core/service/src/engine/centralized/service/crs_gen.rs | Import ordering for rustfmt. |
| core/service/src/engine/centralized/endpoint.rs | Generic impl formatting + improved error formatting. |
| core/service/src/cryptography/signatures.rs | Import ordering for rustfmt. |
| core/service/src/cryptography/mod.rs | Minor import order change (cfg-gated). |
| core/service/src/cryptography/hybrid_ml_kem.rs | Import ordering for rustfmt. |
| core/service/src/cryptography/encryption.rs | Import ordering for rustfmt. |
| core/service/src/cryptography/decompression.rs | Import ordering for rustfmt. |
| core/service/src/cryptography/attestation/nitro_mock.rs | Import ordering for rustfmt. |
| core/service/src/cryptography/attestation/mod.rs | Import ordering + ensure formatting. |
| core/service/src/consts.rs | Import ordering for rustfmt. |
| core/service/src/conf/threshold.rs | Rust 2024 if let ... && ... chain simplifications; match ergonomics (ref removal). |
| core/service/src/conf/mod.rs | Import ordering for rustfmt. |
| core/service/src/client/user_decryption_non_wasm.rs | Import ordering for rustfmt. |
| core/service/src/client/tests/threshold/restore_from_backup_tests_isolated.rs | Import ordering for rustfmt. |
| core/service/src/client/tests/threshold/public_decryption_tests.rs | Import ordering for rustfmt. |
| core/service/src/client/tests/threshold/nightly_tests.rs | Import ordering for rustfmt. |
| core/service/src/client/tests/threshold/mpc_epoch_tests.rs | Import ordering + multi-import reordering. |
| core/service/src/client/tests/threshold/mpc_context_tests.rs | Import ordering for rustfmt. |
| core/service/src/client/tests/threshold/key_gen_tests.rs | Import ordering for rustfmt. |
| core/service/src/client/tests/threshold/key_gen_tests_isolated.rs | Import ordering for rustfmt. |
| core/service/src/client/tests/threshold/custodian_context_tests.rs | Import ordering for rustfmt. |
| core/service/src/client/tests/threshold/custodian_backup_tests.rs | Formatting (derive_request_id call) + import ordering. |
| core/service/src/client/tests/threshold/common.rs | Import ordering for rustfmt. |
| core/service/src/client/tests/common.rs | Import ordering for rustfmt. |
| core/service/src/client/tests/centralized/user_decryption_tests.rs | Import ordering for rustfmt. |
| core/service/src/client/tests/centralized/restore_from_backup_tests_isolated.rs | Import ordering for rustfmt. |
| core/service/src/client/tests/centralized/public_decryption_tests.rs | Import ordering for rustfmt. |
| core/service/src/client/tests/centralized/nightly_tests.rs | Import ordering for rustfmt. |
| core/service/src/client/tests/centralized/misc_tests.rs | Import ordering + assertion formatting. |
| core/service/src/client/tests/centralized/misc_tests_isolated.rs | Import ordering for rustfmt. |
| core/service/src/client/tests/centralized/key_gen_tests.rs | Import ordering for rustfmt. |
| core/service/src/client/tests/centralized/custodian_context_tests.rs | Import ordering for rustfmt. |
| core/service/src/client/tests/centralized/custodian_backup_tests.rs | Import ordering for rustfmt. |
| core/service/src/client/tests/centralized/crs_gen_tests.rs | Import ordering for rustfmt. |
| core/service/src/client/test_tools.rs | Import ordering + tonic_health imports reordered. |
| core/service/src/client/public_decryption.rs | Import ordering for rustfmt. |
| core/service/src/client/key_gen.rs | Import ordering + multiline error formatting. |
| core/service/src/client/js_api.rs | Tuple-field access spacing normalized; import ordering. |
| core/service/src/client/custodian_context.rs | Import ordering for rustfmt. |
| core/service/src/client/crs_gen.rs | Import ordering for rustfmt. |
| core/service/src/client/client_non_wasm.rs | Import ordering for rustfmt. |
| core/service/src/bin/kms-gen-keys.rs | Rust 2024 if let ... && ... chain simplifications; import ordering. |
| core/service/src/bin/kms-custodian.rs | Import ordering + log formatting. |
| core/service/src/backup/tests.rs | Import ordering for rustfmt. |
| core/service/src/backup/seed_phrase.rs | Import ordering for rustfmt. |
| core/service/src/backup/mod.rs | Import ordering for rustfmt. |
| core/grpc/src/identifiers.rs | Import ordering for rustfmt. |
| core-client/tests/kind-testing/kubernetes_test_threshold_isolated.rs | Panic formatting (rustfmt). |
| core-client/tests/kind-testing/kubernetes_test_centralized_isolated.rs | Print formatting (rustfmt). |
| core-client/tests/integration/integration_test.rs | Import ordering + assertion formatting. |
| core-client/tests/integration/integration_test_isolated.rs | Import ordering for rustfmt. |
| core-client/test-utils-cc/src/lib.rs | Mark env::set_var calls unsafe for Rust 2024 (test utility). |
| core-client/src/s3_operations.rs | Log formatting and multiline error formatting. |
| core-client/src/mpc_epoch.rs | Import ordering + ensure formatting. |
| core-client/src/mpc_context.rs | Rust 2024 if let ... && ... chain simplification in warnings; import ordering. |
| core-client/src/keygen.rs | Log formatting + import ordering. |
| core-client/src/decrypt.rs | Import ordering for rustfmt. |
| core-client/src/crsgen.rs | Import ordering for rustfmt. |
| core-client/src/bin.rs | Import ordering for rustfmt. |
| core-client/src/backup.rs | Import ordering + error formatting. |
| Cargo.toml | Set workspace package edition to 2024. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dd23
reviewed
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noisy PR, but it all breaks down to a few changes repeated all over:
genis a keyword now, so therandcrate's.gen()method has to be called with.r#gen()which is fugly but will likely go away when upgrading; same for much other grpc related code. We had one struct member namedgenwhich I renamedgenerator. Example hereif let Some(x) = y { if x > z { … … } }is a pretty common pattern but in ed2024 we can doif let Some(x) = y && x > z { … … }instead, avoiding the nested if. Noisy change, but nicer. Example hereimpl Trait. I had great help from the AI on this one because it was a bit of a head scratcher. See here.match Some(ref x)ormatch Some(ref mut x). This is no longer needed and Rust figures out on its own what we want. Example here.std::env::set_varis nowunsafe. We set a lot of env-vars, so now we have a lot of unsafe code... Example here.cargo fmt --allwas applied in 81dfe1c – reviewers might want to review this PR commit by commit to avoid eye bleed.