Conversation
There was a problem hiding this comment.
Pull request overview
Adds repository guidance and configuration for AI coding agents (including Claude), plus an architecture overview document for the KMS repo.
Changes:
- Added
ARCHITECTURE.mddescribing system context, workspace layout, and key subsystems. - Added
AGENTS.mddefining expectations/rules for AI coding agents in this repo. - Added Claude agent config (
.claude/settings.json) and adjusted.gitignorefor local Claude settings.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ARCHITECTURE.md | New architecture documentation for the KMS system and repo layout. |
| AGENTS.md | New policy/guidelines for AI coding agents working in this repository. |
| .gitignore | Updates ignore rules around Claude configuration files. |
| .claude/settings.json | Adds shared Claude agent settings (sandbox + ignore/sensitive patterns). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Consolidated Tests Results 2026-04-23 - 13:39:57Test ResultsDetails
test-reporter: Run #1600
🎉 All tests passed!TestsView All Tests
🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
kc1212
left a comment
There was a problem hiding this comment.
I think it's ok for me. but we'll only know how well it works if we try it, I guess. maybe someone else can have a look as well?
Co-authored-by: Daniel Demmler <daniel.demmler@zama.ai>
Co-authored-by: Daniel Demmler <daniel.demmler@zama.ai>
|
As discussed, let's break this up into a very compact root Once we have this in place, we should evaluate how it works for us. |
Co-authored-by: Daniel Demmler <daniel.demmler@zama.ai>
dd23
left a comment
There was a problem hiding this comment.
Thanks! I think this is in good shape now. Let's give it a try.
Description of changes
Added basic context for AIs along with Claude specific configuration information to enhance efficiency and security.
AGENTS.md is hand written and reviewed by Claude whereas ARCHITECTURE.md is written by Claude after reading the code and documentation.
Issue ticket number and link
This closes https://github.com/zama-ai/kms-internal/issues/2971
PR Checklist
I attest that all checked items are satisfied. Any deviation is clearly justified above.
chore: ...).TODO(#issue).unwrap/expect/paniconly in tests or for invariant bugs (documented if present).devopslabel + infra notified + infra-team reviewer assigned.!and affected teams notified.Zeroize+ZeroizeOnDropimplemented.unsafe; if unavoidable: minimal, justified, documented, and test/fuzz covered.Dependency Update Questionnaire (only if deps changed or added)
Answer in the
Cargo.tomlnext to the dependency (or here if updating):More details and explanations for the checklist and dependency updates can be found in CONTRIBUTING.md