Skip to content

CI reform, round 2#541

Merged
dvdplm merged 33 commits intomainfrom
dvdplm/chore/light-touch-ci-reform
Apr 23, 2026
Merged

CI reform, round 2#541
dvdplm merged 33 commits intomainfrom
dvdplm/chore/light-touch-ci-reform

Conversation

@dvdplm
Copy link
Copy Markdown
Contributor

@dvdplm dvdplm commented Apr 21, 2026

Second round of CI tweaks

  • Move clippy and dylint to workspace level: run once for the workspace. Pro: speed. Con: possibly weird feature combos enabled by single crates not caught. This happens in the new rust-lint.yml.
  • s/package-name/crate-names/ for sanity
  • inherit secrets to cut down on the noise – POSSIBLY CONTROVERSIAL (cc @fegmorte)
  • Bump parallelism of the heavy workspace-crates jobs from 4 to 8
  • Use a bigger runner for test-core-client-unit

Measured impact on the workspace-crates job

Job Before After
crates-heavy-1 89m 46m
crates-heavy-2 46m 38m
crates-normies 19m 12m
workspace-utils 15m 4m

After this PR the real hogs are the two jobs running slow_tests (each 2h+).

@cla-bot cla-bot Bot added the cla-signed The CLA has been signed. label Apr 21, 2026
Comment thread .github/workflows/rust-lint.yml Fixed
Comment thread .github/workflows/rust-lint.yml Fixed
Comment thread .github/workflows/rust-lint.yml Fixed
Comment thread .github/workflows/rust-lint.yml Fixed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

Consolidated Tests Results 2026-04-23 - 10:06:48

Test Results

passed 18 passed

Details

tests 18 tests
clock not captured
tool junit-to-ctrf
build build-and-test arrow-right test-reporter link #1587
pull-request CI reform, round 2 link #541

test-reporter: Run #1587

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
18 18 0 0 0 0 0 not captured

🎉 All tests passed!

Tests

View All Tests
Test Name Status Flaky Duration
nightly_full_gen_tests_k8s_default_threshld_sequential_crs 33.0s
test_k8s_threshld_insecure 3m 15s
k8s_test_crs_uniqueness 33.0s
k8s_test_insecure_keygen_encrypt_and_public_decrypt 3m 17s
k8s_test_insecure_keygen_encrypt_multiple_types 3m 37s
k8s_test_keygen_and_crs 3m 16s
k8s_test_keygen_uniqueness 9m
nightly_full_gen_tests_k8s_default_threshld_sequential_crs 32.8s
test_k8s_threshld_insecure 3m 15s
k8s_test_crs_uniqueness 32.9s
k8s_test_insecure_keygen_encrypt_and_public_decrypt 3m 20s
k8s_test_insecure_keygen_encrypt_multiple_types 3m 42s
k8s_test_keygen_and_crs 3m 16s
k8s_test_keygen_uniqueness 8m 57s
nightly_full_gen_tests_k8s_default_centralzd_sequential_crs 1.8s
test_k8s_centralzd_insecure 1m 2s
k8s_test_centralized_insecure 1m 2s
nightly_full_gen_tests_default_k8s_centralized_sequential_crs 1.8s

🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@dvdplm dvdplm marked this pull request as ready for review April 22, 2026 07:47
@dvdplm dvdplm requested review from a team as code owners April 22, 2026 07:47
fegmorte
fegmorte previously approved these changes Apr 23, 2026
Copy link
Copy Markdown
Contributor

@fegmorte fegmorte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

permissions without explanatory comments: Look at the other WF, we set a comment for each permission
secrets referenced without a dedicated environment: Set a comment to ignore this warning in ./kms/.github/zizmor.yml

fegmorte
fegmorte previously approved these changes Apr 23, 2026
Comment thread .github/workflows/common-testing.yml
Comment thread .github/workflows/rust-lint.yml
fegmorte
fegmorte previously approved these changes Apr 23, 2026
@dvdplm dvdplm dismissed fegmorte’s stale review April 23, 2026 15:53

The merge-base changed after approval.

Comment thread .github/workflows/main.yml
Copy link
Copy Markdown
Member

@dd23 dd23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a go!

@dvdplm dvdplm merged commit fc4ab0b into main Apr 23, 2026
51 checks passed
@dvdplm dvdplm deleted the dvdplm/chore/light-touch-ci-reform branch April 23, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants