feat(ci): pro 319 test ensure proper linting for each sub repo#123
Open
Seth-Schmidt wants to merge 9 commits intomainfrom
Open
feat(ci): pro 319 test ensure proper linting for each sub repo#123Seth-Schmidt wants to merge 9 commits intomainfrom
Seth-Schmidt wants to merge 9 commits intomainfrom
Conversation
jatZama
approved these changes
Apr 28, 2026
Seth-Schmidt
force-pushed
the
feature/pro-319-test-ensure-proper-linting-for-each-sub-repo-and-add-lint-to
branch
from
e0b9633 to
b253666
Compare
jatZama
reviewed
Apr 29, 2026
| You just have to run: | ||
|
|
||
| ```npx hardhat lz:oapp:wire --oapp-config layerzero.config.mainnet.hyperevm.ts --skip-connections-from-eids <EID_ETHEREUM_V2_MAINNET>``` | ||
| `npx hardhat lz:oapp:wire --oapp-config layerzero.config.mainnet.hyperevm.ts --skip-connections-from-eids <EID_ETHEREUM_V2_MAINNET>` |
Member
There was a problem hiding this comment.
This is wrong, please keep the triple quotes here, since it shows differently. ``` above and below of the command. This should be allowed by the linter, see the other instances of triple quotes in same file already existing.
Contributor
Author
Contributor
Author
|
@claude review |
|
Claude finished @Seth-Schmidt's request. — View run |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
@claude review |
|
Claude finished @Seth-Schmidt's request. — View run |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
- Added a linting step to the GitHub Actions workflow for the contracts/safe directory to ensure code quality. - Updated the README.md to clarify the deployment instructions for the multisig safe wallet, including environment variable setup and command execution.
- Introduced a linting step in the GitHub Actions workflow for the governance contracts to ensure code quality. - Updated the README.md to improve clarity on deployment instructions, including formatting adjustments for better readability. - Refactored imports in task files to maintain consistency and organization.
- Introduced a linting step in the GitHub Actions workflow for the Solana OFT contracts to enhance code quality. - Updated `.eslintignore` and `.prettierignore` to exclude additional files and directories. - Made minor formatting adjustments in `ADD_SOLANA_OFT_TESTNET.md` and `README.md` for improved readability. - Added a new dependency for ESLint configuration in `package.json` and updated the lock file accordingly.
- Introduced a linting step in the GitHub Actions workflow for the contracts/token directory to enhance code quality. - Updated ESLint version in `package.json` and `pnpm-lock.yaml` to ensure compatibility. - Made minor formatting adjustments in `ADD_BNB_OFT.md` and `ADD_HYPEREVM_OFT.md` for improved readability. - Refactored scripts in `convertToAragonProposal.ts` and `copyAbiToDeployments.ts` for consistency and clarity.
- Removed the Solidity linting command from the CI workflow for the contracts/safe directory, streamlining the linting process to only include Prettier checks.
- Updated the CI workflow for the contracts/safe directory to include both Prettier and Solidity linting checks, ensuring improved code quality. - Added a new .solhint.json configuration file to define Solidity linting rules, currently set to an empty object for future customization.
Seth-Schmidt
force-pushed
the
feature/pro-319-test-ensure-proper-linting-for-each-sub-repo-and-add-lint-to
branch
from
b253666 to
0a6be43
Compare
Contributor
Author
|
@claude review |
|
Claude finished @Seth-Schmidt's request. — View run |
|
[AUTOMATED] Code Review✅ No issues found. This PR was reviewed for bugs, security vulnerabilities, guideline compliance, and error handling quality. Summary of ChangesThis PR adds CI lint steps to 4 workflow files and fixes several linting/tooling issues across sub-repos:
Review Details
|
|
The review is complete. Here's a summary: PR #123 Review Complete ✅No issues found across all review dimensions:
The PR is a well-scoped CI improvement that adds linting steps to 4 workflows and fixes the necessary tooling issues (ESLint version mismatch, ajv override, missing solhint config) to make those lint steps pass. The review comment has been posted to the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added linting workflow step to 4 workflows. Also performed any missing linting on files already committed.
NOTE:
.github/workflows/contracts-governance-tests.ymlis only usinglint:jsas to not modify the existing contract files which have been deployed since those will flag linting errors in their current state.In
contracts/token: ESLint was brought up to9.26.0by a dependabot PR, however,tokenis using@layerzerolabs/eslint-config-nextwhich only allows up to8.57.1. I have downgraded ESLint back to8.57.1for now.See below for other minor fixes.
Workflows with lint steps added
contracts-governance-tests.ymlpnpm run lint:jscontracts-token-tests.ymlpnpm run lintcontracts-solana-oft-tests.ymlpnpm run lintcontracts-safe-hardhat-tests.ymlnpm run prettier:check && npm run lint:solBug Fixes
contracts/token— ESLint version mismatcheslintfrom^9.26.0to^8.55.0eslint.config.js); the repo uses.eslintrc.jsand@layerzerolabs/eslint-config-nextwhich only supports ESLint^8.55.0contracts/solanaOFT— ESLint crashing due to wrongajvversion"@eslint/eslintrc>ajv": "^6.12.4"topnpm.overridesajv@8.xinto@eslint/eslintrc's scope despite it requiring^6.12.4; this causedeslintrcto callajv._optswhich doesn't exist in v8, crashing ESLintcontracts/safe— Missing solhint config.solhint.jsonwith an empty ruleset sonpm run lint:solcan run without errorscontracts/solanaOFT— Auto-generateddeployments/directory linteddeployments/to both.eslintignoreand.prettierignore