Skip to content

feat: pro-28-test-add-ci-to-run-test-on-changes#85

Merged
Seth-Schmidt merged 12 commits intomainfrom
feature/pro-28-test-add-ci-to-run-test-on-changes
Apr 9, 2026
Merged

feat: pro-28-test-add-ci-to-run-test-on-changes#85
Seth-Schmidt merged 12 commits intomainfrom
feature/pro-28-test-add-ci-to-run-test-on-changes

Conversation

@Seth-Schmidt
Copy link
Copy Markdown
Contributor

@Seth-Schmidt Seth-Schmidt commented Apr 6, 2026

Summary

Adds workflows to run tests on any change for the repos with tests that are missing CI.

Workflows and scopes

  • Token (contracts/token/**): pnpm, compile, unit tests
  • Governance (contracts/governance/**): pnpm, compile, unit tests.
  • Fees burner (contracts/feesBurner/**): npm ci, Hardhat tests.
  • Pauser set wrapper (contracts/pauserSetWrapper/**): npm ci, make test.
  • Solana OFT (contracts/solanaOFT/**): pnpm, Foundry toolchain, pnpm run test:forge.

Tooling

Updates contracts/solanaOFT/foundry.toml to use solc = '0.8.24 (replacing solc-version = '0.8.22')

@cla-bot cla-bot Bot added the cla-signed label Apr 6, 2026
@Seth-Schmidt Seth-Schmidt force-pushed the feature/pro-28-test-add-ci-to-run-test-on-changes branch 3 times, most recently from 00b572c to cbb5f35 Compare April 6, 2026 21:26
@Seth-Schmidt Seth-Schmidt self-assigned this Apr 7, 2026
@Seth-Schmidt Seth-Schmidt marked this pull request as ready for review April 7, 2026 00:33
@Seth-Schmidt Seth-Schmidt requested review from a team and mortendahl as code owners April 7, 2026 00:33
Comment thread contracts/solanaOFT/foundry.toml
Comment thread .github/workflows/contracts-fees-burner-tests.yml Outdated
Copy link
Copy Markdown
Collaborator

@melanciani melanciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's clean the current and new flows by removing the check-changes pattern

@Seth-Schmidt Seth-Schmidt force-pushed the feature/pro-28-test-add-ci-to-run-test-on-changes branch from eb57e87 to 68cfbcb Compare April 8, 2026 01:16
Comment thread .github/workflows/contracts-confidential-token-wrappers-registry-tests.yml Outdated
Copy link
Copy Markdown
Collaborator

@melanciani melanciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think we should filter paths when pushing !

Copy link
Copy Markdown
Collaborator

@melanciani melanciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we 're still missing tests for the safe dir

Copy link
Copy Markdown
Collaborator

@melanciani melanciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot !

@Seth-Schmidt Seth-Schmidt merged commit c717a26 into main Apr 9, 2026
14 checks passed
@Seth-Schmidt Seth-Schmidt deleted the feature/pro-28-test-add-ci-to-run-test-on-changes branch April 9, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants