fix(shortint): add ciphertext_modulus_after_packing_ks to compression…#1851
Open
mayeul-zama wants to merge 1 commit intomainfrom
Open
fix(shortint): add ciphertext_modulus_after_packing_ks to compression…#1851mayeul-zama wants to merge 1 commit intomainfrom
mayeul-zama wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
|
closes zama-ai/tfhe-rs-internal#843 |
mayeul-zama
force-pushed
the
mz/ct_mod_compression
branch
from
ed986cd to
5b02635
Compare
IceTDrinker
reviewed
Jan 2, 2025
| pub lwe_per_glwe: LweCiphertextCount, | ||
| pub storage_log_modulus: CiphertextModulusLog, | ||
| pub packing_ks_key_noise_distribution: DynamicDistribution<u64>, | ||
| pub ciphertext_modulus_after_packing_ks: CiphertextModulus, |
Member
There was a problem hiding this comment.
need an upgrade function + backward data compatibility I would think ?
mayeul-zama
force-pushed
the
mz/ct_mod_compression
branch
from
5b02635 to
7da4353
Compare
mayeul-zama
force-pushed
the
mz/ct_mod_compression
branch
from
7da4353 to
fd554e7
Compare
Member
|
I'm currently doubting whether we should merge this, or wait to have an actual use for it 🤔 |
IceTDrinker
reviewed
Jan 10, 2025
Member
IceTDrinker
left a comment
IceTDrinker
left a comment
There was a problem hiding this comment.
As discussed let's at least unlock power of 2 moduli at the core level so that this change makes sense (sorry about that, wasn't clear at first to me)
mayeul-zama
force-pushed
the
mz/ct_mod_compression
branch
2 times, most recently
from
de1623a to
b67d4ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.