Skip to content

Conversation

@soonum
Copy link
Contributor

@soonum soonum commented Nov 12, 2025

Done to circumvent criterion limitation regarding automatic truncation of long benchmark ID.
Using a println() call we ensure the complete name is displayed before benchmark execution to ease manual parsing and debugging.


This change is Reviewable

Done to circumvent criterion limitation regarding automatic
truncation of long benchmark ID.
Using a println() call we ensure the complete name is displayed
before benchmark execution to ease manual parsing and debugging.
@soonum soonum requested a review from IceTDrinker November 12, 2025 10:31
@soonum soonum self-assigned this Nov 12, 2025
@soonum soonum added the ci label Nov 12, 2025
@cla-bot cla-bot bot added the cla-signed label Nov 12, 2025
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question on something that may cause parsing/display issues

@IceTDrinker reviewed 23 of 23 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @soonum)


tfhe-benchmark/benches/shortint/glwe_packing_compression.rs line 37 at r1 (raw file):

    });

    let bench_id = format!("{bench_name}::unpack_all");

will this create parsing/display issues in Grafana ?

Copy link
Contributor Author

@soonum soonum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @IceTDrinker)


tfhe-benchmark/benches/shortint/glwe_packing_compression.rs line 37 at r1 (raw file):

Previously, IceTDrinker wrote…

will this create parsing/display issues in Grafana ?

These benchmarks are not stored in database.

@soonum soonum requested a review from IceTDrinker November 14, 2025 11:55
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IceTDrinker)

@soonum soonum merged commit ef07963 into main Nov 14, 2025
269 checks passed
@soonum soonum deleted the dt/ci/print_bench_id branch November 14, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants