chore(ci): implement unit test for data_extractor#3108
Open
Conversation
86139f7 to
cb3cf30
Compare
This is the first batch of unit tests. More cases will follow to improve coverage along with integration tests to test file generation.
4d2ead9 to
546def0
Compare
IceTDrinker
reviewed
Dec 11, 2025
Member
IceTDrinker
left a comment
There was a problem hiding this comment.
are the tests run in CI somehow ?
@IceTDrinker reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @soonum)
ci/data_extractor/tests/test_unit.py line 351 at r1 (raw file):
if __name__ == "__main__": unittest.main()
unclear to me whether things are actually tested
ci/data_extractor/tests/__init__.py line 5 at r1 (raw file):
# Add data_extractor sources to the Python path. path = os.path.abspath(os.path.join(os.path.dirname(__file__), "../src"))
this is yuck, isn't there a way to properly load a python module ?
if you need to setup a project with uv (written in rust so should be ok to install) or something please do that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first batch of unit tests. More cases will follow to improve coverage along with integration tests to test file generation.
This change is