Skip to content

Conversation

@ralf401
Copy link
Contributor

@ralf401 ralf401 commented Nov 4, 2025

No description provided.

@ralf401 ralf401 self-assigned this Nov 4, 2025
@ralf401 ralf401 linked an issue Nov 4, 2025 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Artifacts

Produced during runtime

📦 epub-6a87e01
📦 html-6a87e01
📦 htmlzip-6a87e01

@ralf401 ralf401 changed the title Draft: Fixes #727 - Add Redis Sentinel environment variables Fixes #727 - Add Redis Sentinel environment variables Nov 5, 2025
@ralf401
Copy link
Contributor Author

ralf401 commented Nov 5, 2025

@mgruner I tried to include it in the environment variables page but decided against it. Now there is a new page in the "Appendix" section.

Additionally, I slightly rephrased the Redis section in the prerequisites and added a sentence to the already existing REDIS_URL variable in the environment variables page with a link to this new page.

Just one thing I noticed: the environment variables page says Please note that this method currently does not allow authentication for the REDIS_URL variable. However, I understood that this is possible via URL and added redis://user:[email protected] as an example to the new page for standard setups. I guess one of them is wrong?

Feel free to even suggest a complete rework... I could not really find additional information which could be useful for admins...

@ralf401 ralf401 requested a review from mgruner November 5, 2025 10:55
@mgruner
Copy link
Contributor

mgruner commented Nov 5, 2025

Looks good to me!

Just one thing I noticed: the environment variables page says Please note that this method currently does not allow authentication for the REDIS_URL variable. However, I understood that this is possible via URL and added redis://user:[email protected] as an example to the new page for standard setups. I guess one of them is wrong?

Yes, I also believe that credentials can be passed in via the URL. You can try this locally with a standard Redis setup. Maybe you can get it to fail when supplying username/password if it is not needed by the redis service, maybe you have to set up the redis service with authentication first. Would be good to unify this, and remove this restriction.

Copy link
Contributor

@mgruner mgruner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Consider removing the username/password discrepancy/restriction.

@ralf401
Copy link
Contributor Author

ralf401 commented Nov 6, 2025

@mgruner Thanks! I tested it and after some hassle it worked in the docker compose stack. So I removed the part that no authentication is possible.

@ralf401 ralf401 merged commit c30b262 into pre-release Nov 6, 2025
1 check passed
@ralf401 ralf401 deleted the rsc/fixes/727 branch November 6, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Redis Sentinel configuration

3 participants