Skip to content

Make S3OutputLocation optional when Workgroup is supplied#21

Merged
zaneli merged 1 commit into
zaneli:masterfrom
exoego:workgroup
Aug 9, 2025
Merged

Make S3OutputLocation optional when Workgroup is supplied#21
zaneli merged 1 commit into
zaneli:masterfrom
exoego:workgroup

Conversation

@exoego

@exoego exoego commented Aug 9, 2025

Copy link
Copy Markdown
Contributor

Closes #18

@exoego exoego changed the title S3OutputLocation is optional when Workgroup is supplied Make S3OutputLocation optional when Workgroup is supplied Aug 9, 2025
@zaneli

zaneli commented Aug 9, 2025

Copy link
Copy Markdown
Owner

Oh, I didn't know that.
https://docs.aws.amazon.com/athena/latest/ug/jdbc-v3-driver-basic-connection-parameters.html#jdbc-v3-driver-output-location

By the way, would it be better to treat OutputLocation as a priority over S3OutputLocation? 🤔

@exoego

exoego commented Aug 9, 2025

Copy link
Copy Markdown
Contributor Author

By the way, would it be better to treat OutputLocation as a priority over S3OutputLocation? 🤔

I think it is better since deprecated parameters may be deleted in future version.
But i want to keep this PR simple.

@zaneli zaneli merged commit ebecf8e into zaneli:master Aug 9, 2025
3 checks passed
@exoego exoego deleted the workgroup branch August 9, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: S3OutputLocation(Prefix) should be optional when Workgroup specified

2 participants