Deprecate keep_warm in favor of AWS-native cold start solutions#1452
Open
Deprecate keep_warm in favor of AWS-native cold start solutions#1452
Conversation
- Regenerate README TOC after renaming heading to "Keeping The Server Warm (Deprecated)" - Add setUp/tearDown to TestKeepWarmDeprecation to set AWS_DEFAULT_REGION, matching pattern used by TestZappa class to avoid botocore NoRegionError in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keep_warmdefault fromtruetofalsedeploy/update/schedulewhenkeep_warmis enabledDeprecationWarninginkeep_warm_callbackhandlerContext
Investigation in #1445 confirmed that
keep_warm:AWS-native alternatives are superior:
The feature remains functional for users who explicitly opt in. Full removal planned for a future major version.
Closes #1451
Test plan
keep_warm: truekeep_warm: falsekeep_warm_callbackemitsDeprecationWarningfalse