Blog - Timing Rule Splits/Changes#3161
Merged
Merged
Conversation
Member
|
Great job, no security vulnerabilities found in this Pull Request |
thc202
reviewed
Jul 18, 2025
kingthorin
force-pushed
the
split-blog
branch
3 times, most recently
from
July 20, 2025 21:04
3dad00e to
ee1424f
Compare
psiinon
requested changes
Jul 21, 2025
kingthorin
force-pushed
the
split-blog
branch
2 times, most recently
from
July 21, 2025 10:07
afcac9a to
40f8d28
Compare
psiinon
reviewed
Jul 21, 2025
|  | ||
|
|
||
| These changes were made to provide users with greater flexibility in creating scan policies. | ||
| In the last few years a number of changes have been implemented to address the potential for false positives.¹ |
Member
There was a problem hiding this comment.
These 2 statements dont really seem to flow for me :/
Member
Author
There was a problem hiding this comment.
I left it just with the first statement. Put the superscript 1 marks on the two rules themselves, and re-jigged the footnote a bit.
psiinon
reviewed
Jul 21, 2025
|
|
||
| #### Alert Tag TEST_TIMING | ||
|
|
||
| The rules (and alerts) are now also decorated with the [TEST_TIMING](/alerttags/test_timing/)[Alert Tag](/docs/desktop/ui/dialogs/addalert/#alert-tags). |
Member
There was a problem hiding this comment.
Needs a space between TEST_Timing & Alert Tag. TBH Not sure the 2nd link is needed..
psiinon
reviewed
Jul 21, 2025
|
|
||
| The rules (and alerts) are now also decorated with the [TEST_TIMING](/alerttags/test_timing/)[Alert Tag](/docs/desktop/ui/dialogs/addalert/#alert-tags). | ||
|
|
||
| ### New Passive Scan Rule - ZAP is Out of Date |
Member
There was a problem hiding this comment.
I'm now having second thoughts about including this - it doesnt seem to be releated to the rest of the post?
kingthorin
force-pushed
the
split-blog
branch
2 times, most recently
from
July 21, 2025 12:55
bba8e14 to
0b948c5
Compare
Member
|
The title PR/commit message should be updated if the new passive scan rule is no longer being included. |
thc202
reviewed
Jul 21, 2025
kingthorin
force-pushed
the
split-blog
branch
4 times, most recently
from
July 22, 2025 11:16
dce285f to
1326e75
Compare
thc202
changed the title
thc202
reviewed
Jul 22, 2025
kingthorin
force-pushed
the
split-blog
branch
2 times, most recently
from
July 22, 2025 11:33
3a2427e to
0c62af5
Compare
Member
Author
|
Done & done |
psiinon
approved these changes
Jul 22, 2025
Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
thc202
approved these changes
Jul 22, 2025
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential Images