Skip to content

feat: use builtin ORAS cache for skeleton packages #3782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented May 9, 2025

Description

In #3767 we created a generic cache for ORAS layers. This is used by default, but we also have a special implementation of caching specifically for skeleton packages. This PR removes that implementation so only the generic cache is used.

Checklist before merging

Copy link

netlify bot commented May 9, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 9977283
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/68221aa91503cf0008c44fff

Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager2/layout/import.go 7.69% 12 Missing ⚠️
src/pkg/zoci/common.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/packager/pull.go 0.00% <ø> (ø)
src/pkg/zoci/common.go 0.00% <0.00%> (ø)
src/internal/packager2/layout/import.go 49.87% <7.69%> (+0.12%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 force-pushed the use-oci-cache-for-skeleton-packages branch from aabfa4b to e641e4c Compare May 9, 2025 20:26
@AustinAbro321 AustinAbro321 marked this pull request as ready for review May 9, 2025 20:34
@AustinAbro321 AustinAbro321 requested review from a team as code owners May 9, 2025 20:34
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 marked this pull request as draft May 9, 2025 20:38
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant