feat: add checking in remote repo if manifest is a chart

[a1994sc]

Description

Makes call to zarf registry when trying to mutate ocirepo resource, and checks if the manifest is a helm chart

Related Issue

Fixes #3435

Checklist before merging

• Test, docs, adr added or updated as needed
• Contributor Guide Steps followed

[netlify]

✅ Deploy Preview for zarf-docs canceled.

Name	Link
🔨 Latest commit	1a89c64
🔍 Latest deploy log	https://app.netlify.com/projects/zarf-docs/deploys/68434f2576f1150008f039a8

[a1994sc]

Hey team, I believe that this PR is in a better state to be reviewed. I have fixed the unit tests to maintained backwards-compatibility with the current logic, e.i. if A) it can not reach the zarf registry, or B) if the media type is not of type helm. I also included a new unit test for checking with an in-memory registry, shoot-out to @brandtkeller for the awesome help both here in the PR and in DM's .

Please let me know if there are any changes you would like to make

Edit:

I will be also updating the docs and what not, so well the code stuff is ready for review the UX/docs needs to be updated

[AustinAbro321]

This is an excellent start, thank you for doing research and driving this forward!

[codecov]

Codecov Report

Attention: Patch coverage is 81.48148% with 10 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/internal/agent/hooks/common.go	80.55%	5 Missing and 2 partials ⚠️
src/internal/agent/hooks/flux-ocirepo.go	83.33%	2 Missing and 1 partial ⚠️

Files with missing lines	Coverage Δ
src/internal/agent/hooks/flux-ocirepo.go	81.73% <83.33%> (+0.29%)	⬆️
src/internal/agent/hooks/common.go	83.33% <80.55%> (-16.67%)	⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[a1994sc]

This is an excellent start, thank you for doing research and driving this forward!

No problem at all!

[AustinAbro321]

A few nits, and some test cleanup to be done. Overall changes are looking good.

[AustinAbro321]

Instead of a new function here we should move these into the existing function. We actually want the registry to be setup for the other test as currently the test takes an extra 10 seconds so it can timeout

[a1994sc]

Tbh, the separate function was mostly so that I can focus my tests on the function I was creating, so I can merge that back into one function without too much issue

[a1994sc]

So I update the tests into one, had to change some of the existing tests to match the new url.... but I'm having issues with the test that use a custom svc such as here:

zarf/src/internal/agent/hooks/flux-ocirepo_test.go

Lines 317 to 336 in 420c4c9

	svc: &corev1.Service{
	TypeMeta: metav1.TypeMeta{
	APIVersion: corev1.SchemeGroupVersion.String(),
	Kind: "Service",
	},
	ObjectMeta: metav1.ObjectMeta{
	Name: "zarf-docker-registry",
	Namespace: "zarf",
	},
	Spec: corev1.ServiceSpec{
	Type: corev1.ServiceTypeNodePort,
	Ports: []corev1.ServicePort{
	{
	NodePort: int32(31999),
	Port: 5000,
	},
	},
	ClusterIP: "10.11.12.13",
	},
	},

Any input on how to update the tests would be great!