-
Notifications
You must be signed in to change notification settings - Fork 54
RFC: Depend on obspec_utils for ObstoreReader, ObjectStoreRegistry #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
==========================================
- Coverage 89.22% 88.75% -0.48%
==========================================
Files 34 34
Lines 1987 1912 -75
==========================================
- Hits 1773 1697 -76
- Misses 214 215 +1
🚀 New features to boost your workflow:
|
|
This is technically a breaking change to the API, because the type of he ObjectStoreRegistry has changed. (Note that it literally changes the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me
I'll think on this a bit more. I forgot that a reason for obspec-utils was not only to have the code available as a lighter dependency but also to change the typing from obstore-based to obspec-based, which would be good to test before obspec-utils is a dependency of virtualizarr |
I think that
ObstoreReaderandObjectStoreRegistryare useful outside of virtualizarr (e.g., for earthaccess) and should therefore be a separate library. I started obspec-utils accordingly, in line with some past discussions.