Use pytest.skipif
to properly report skipped CRC32C codec tests
#740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests
test_err_location
,test_repr
, andtest_backwards_compatibility
were not reporting that they were skipped if thecrc32c
dependency wasn't available/installed, as they weren't marked with the appropriate markers. This PR skips these tests at thepytest
level rather than using ahas_crc32c
check that defines the tests at collection. I've parametrized most of these tests. I had to split up thetest_backwards_compatibility
test into two, asCRC32C()
wouldn't be defined if it were not installed (I don't think it makes sense to mock it just for one test).Closes #640
TODO: