Skip to content

update pcodec#817

Open
mwlon wants to merge 10 commits intozarr-developers:mainfrom
mwlon:pcodec-v1
Open

update pcodec#817
mwlon wants to merge 10 commits intozarr-developers:mainfrom
mwlon:pcodec-v1

Conversation

@mwlon
Copy link
Copy Markdown
Contributor

@mwlon mwlon commented Feb 12, 2026

Fixes #815 . Updated to >=v1, which has various improvements.

Signed-off-by: mwlon <m.w.loncaric@gmail.com>
Signed-off-by: mwlon <m.w.loncaric@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.23%. Comparing base (1fdde70) to head (686e8be).

❌ Your project check has failed because the head coverage (98.23%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #817      +/-   ##
===========================================
- Coverage   100.00%   98.23%   -1.77%     
===========================================
  Files           27       27              
  Lines          901      905       +4     
===========================================
- Hits           901      889      -12     
- Misses           0       16      +16     
Files with missing lines Coverage Δ
src/numcodecs/pcodec.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: mwlon <m.w.loncaric@gmail.com>
Signed-off-by: mwlon <m.w.loncaric@gmail.com>
Signed-off-by: mwlon <m.w.loncaric@gmail.com>
Signed-off-by: mwlon <m.w.loncaric@gmail.com>
@mwlon
Copy link
Copy Markdown
Contributor Author

mwlon commented Feb 15, 2026

CI appears to be failing for unrelated reasons.

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor

DimitriPapadopoulos commented Apr 12, 2026

I understand pcodec now supports Python 3.14. Could you address this comment?

# TODO: Remove this conditional when pcodec supports Python 3.14
if [[ "${{ matrix.python-version }}" == "3.14" ]]; then
python -m pip install -v ".[test,test_extras,msgpack,google_crc32c,crc32c,zfpy]"
else
python -m pip install -v ".[test,test_extras,msgpack,google_crc32c,crc32c,pcodec,zfpy]"
fi

Also, please rebase to resolve conflicts and hopefully fix CI failures.

mwlon added 2 commits April 12, 2026 19:59
Signed-off-by: mwlon <m.w.loncaric@gmail.com>
@mwlon
Copy link
Copy Markdown
Contributor Author

mwlon commented Apr 13, 2026

@DimitriPapadopoulos keen eye, updated ci.yaml.

@mwlon
Copy link
Copy Markdown
Contributor Author

mwlon commented Apr 15, 2026

@DimitriPapadopoulos want to review this?

Copy link
Copy Markdown
Contributor

@DimitriPapadopoulos DimitriPapadopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the update (and hence the suggested deprcation warning) should be part of the next minor release, not a patch release.

As far as I can see, pcodec does not require specific, recent versions of Python. Therefore, I am confident it supports requires-python = ">=3.12".

I haven't found the time to understand the details of the new fixture yet. Can you perhaps explain why there's no fixture/pcodec/array.10.npy file and what the filtered warning caused by "old fixture files" is about? Is it not possible to update the fixture files?

Comment thread src/numcodecs/pcodec.py Outdated
Comment thread src/numcodecs/pcodec.py Outdated
mwlon added 2 commits April 18, 2026 08:26
Signed-off-by: mwlon <m.w.loncaric@gmail.com>
Signed-off-by: mwlon <m.w.loncaric@gmail.com>
@mwlon
Copy link
Copy Markdown
Contributor Author

mwlon commented Apr 18, 2026

@DimitriPapadopoulos To answer your questions:

  • Yes, pcodec supports >= python 3.12 (and <= 3.14 at the moment)
  • There's no new .npy because we didn't add any new arrays - we only added a new codec. The test runs the Cartesian product of arrays x codecs.

Should be ready for review again, except CI is again failing for unrelated reasons on Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Pcodec to v1

2 participants