Skip to content

Fix HttpStore #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 9, 2025
Merged

Fix HttpStore #12

merged 10 commits into from
Feb 9, 2025

Conversation

brokkoli71
Copy link
Member

This PR fixes the HttpStore which requested 2 bytes too many resulting in an error while decoding blosc.

Other changes:

  • Updated and tested example in README.md
  • Added test to compare results of reading from HttpStore and FilesystemStore
  • better exception message if requested data is out of range of array

@brokkoli71 brokkoli71 changed the title Fix http store Fix HttpStore Feb 5, 2025
normanrz
normanrz approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@normanrz normanrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you please also have a look at the failing CI?

@brokkoli71 brokkoli71 requested a review from normanrz February 9, 2025 13:34
@normanrz normanrz merged commit 339a48f into zarr-developers:main Feb 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanrz normanrz Awaiting requested review from normanrz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with hierarchy.get in README
2 participants
@brokkoli71 @normanrz