Skip to content

Test of detection of invalid codec order and invalid TransposeCodec #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

brokkoli71
Copy link
Member

This PR is a small addition to #6 based on #6 (review)

  • test if invalid codec orders get detected
  • refactored the test for invalid transpose codecs
  • both checks during runtime were already implemented

extract testCheckInvalidTransposeOrder from testTransposeCodec
@brokkoli71 brokkoli71 requested a review from normanrz August 15, 2024 14:03
@normanrz normanrz merged commit e3e2208 into zarr-developers:main Aug 15, 2024
3 checks passed
@sbesson
Copy link
Contributor

sbesson commented Aug 15, 2024

Thanks @brokkoli71 and @normanrz, great to see additional coverage of this validation logic. From our side, it would be useful to have this feature available in a release artifact. Would it make sense to schedule a patch release of zarr-java or do you have other in-progress work?

Re release, am I correct that all that is needed is to bump the version in the pom.xml, push a tag and the GitHub workflow should handle the deployment to Maven Central?

@normanrz
Copy link
Member

Re release, am I correct that all that is needed is to bump the version in the pom.xml, push a tag and the GitHub workflow should handle the deployment to Maven Central?

I just created a new release. Yeah, just create a new tag and the Github CI will take care of deployment. You can even create the new tag from the Github UI via the Releases page.

@normanrz normanrz deleted the check-sharding-bounds branch August 22, 2024 12:55
@sbesson
Copy link
Contributor

sbesson commented Aug 22, 2024

Looking at https://github.com/zarr-developers/zarr-java/actions/runs/10505611095/job/29103503907, it looks like the workflow tried to create a 0.0.2 version again. I think

<version>0.0.2</version>
needs to be updated prior to tagging (and maybe we switch back to SNAPSHOT after release as per the standard Java development workflow?)

@sbesson sbesson mentioned this pull request Aug 22, 2024
@normanrz
Copy link
Member

🤦 Ok. Thanks for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants