Skip to content

Additional testing for AsyncArray, Array #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Additional testing for AsyncArray, Array #3049

wants to merge 13 commits into from

Conversation

brokkoli71
Copy link
Member

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label May 8, 2025
brokkoli71
brokkoli71 commented May 9, 2025
View reviewed changes
src/zarr/core/array.py Outdated
return ArrayV2Metadata.from_dict(data)
else:
raise ValueError(f"Invalid zarr_format: {zarr_format}. Expected 2 or 3")
raise TypeError
Copy link
Member Author

@brokkoli71 brokkoli71 May 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this necessary? If the data argument follows the type annotations, this should not be possible

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but if the data doesn't follow the type hint, then you can get unpredictable errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-v-b d-v-b d-v-b left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brokkoli71 @d-v-b