feat(sharding): lift constraint on evenly divisible subchunk shapes#370
feat(sharding): lift constraint on evenly divisible subchunk shapes#370LDeakin wants to merge 1 commit intozarr-developers:mainfrom
Conversation
|
Thanks! I can see the rationale of this change for the rectilinear chunk grid. However, I would favor keeping the strict requirement for regular outer chunk grids. That way, implementations that don't implement the rectilinear grid won't need to change. |
I'm interested to hear more perspectives here. Personally, I think this change is very useful with regularly gridded arrays, and irregular grids just make the problem far more apparent. For example, say a chunk shape is constrained by a sensor or data pipeline and must be Would it be sufficient in your view to recommend that implementations that add support for this issue a warning that it will not be supported by impls that only support version 1.0 of the sharding codec? |
|
+1 to this change, it seems like a logical extension of how we currently handle the shape / chunk grid relationship for the regular chunk grid. |
xref: zarr-developers/zarr-extensions#34