Skip to content

Conversation

@LDeakin
Copy link
Member

@LDeakin LDeakin commented Nov 15, 2024

I would prefer to see the legacy vlen codecs merged into one for Zarr V3, but this supports what zarr-python v3.0.0 is doing.

@codecov
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.75%. Comparing base (108cd0b) to head (5044e60).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
zarrs/src/config.rs 87.50% 1 Missing ⚠️
zarrs_metadata/src/v2/array.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   81.61%   81.75%   +0.13%     
==========================================
  Files         166      166              
  Lines       23556    23571      +15     
==========================================
+ Hits        19226    19270      +44     
+ Misses       4330     4301      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDeakin LDeakin merged commit 4919074 into main Nov 15, 2024
@LDeakin LDeakin deleted the zarr_python_string_compat branch November 15, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants