Add socket_id
to UIEventArguments
; use new client.target
where possible
#4335
+105
−67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #4016 and feature request #4218:
client.individual_target
context.ui.navigate
,ui.download()
andui.notify()
should adhere to theclient.individual_target
context.ui.download()
on the auto-index page (without usingclient.individual_target
) should raise an exception.Unfortunately, the current implementation has one main drawback:
The PR is still a draft because we're thinking about alternative solutions, like automatically calling event handlers in the context of the current socket. This would automatically trigger notifications, downloads and navigations on the socket that caused the event. But it could also affect
run_method()
andrun_javascript()
calls, which might not be desired.