Skip to content

fix: bound order-watch deadlines; add wiring audit and API harvest plan - #106

Merged
zaydiscold merged 3 commits into
mainfrom
codex/robinhood-wiring-audit-2026-09-06
Sep 8, 2026
Merged

zaydiscold merged 3 commits into
mainfrom
codex/robinhood-wiring-audit-2026-09-06

Conversation

@zaydiscold

Copy link
Copy Markdown
Owner

What changes

  • Bounds observation even when a poll or injected sleep never settles.
  • Bounds the mandatory final reconciliation read separately: default final budget is min(timeoutMs, 5000).
  • Honors a supplied abort signal immediately while waiting and skips final reconciliation on explicit cancellation.
  • Caps long polling sleeps to remaining observation time, rejects invalid/overflowing timer values before reads, and consumes late callback rejection.
  • Preserves the current output schema and retrySafe: false; no order is resubmitted.
  • Adds 12 targeted regression cases and an evidence-based CLI/MCP wiring audit, modernization strategy, feature roadmap, and exact capture work packages.

Reproduced baseline

The original lifecycle module was reconstructed locally and verified against Git blob 08ec190e3b7960ed6bca5b8df07243311a49cbb8. A never-settling poll remained pending beyond both a 10 ms observation timeout and explicit cancellation.

Validation performed

  • Isolated strict TypeScript compilation passed.
  • All 12 committed regression assertions passed locally with Node's native test runner, changing only the runner import and module path for that local harness.
  • Full workspace build, Vitest, dependency install, and supported-OS matrix were not run locally. Review the actual CI checks on this PR; local results are not a substitute.

Explicit boundaries

This stops the observer waiting; it does not cancel underlying HTTP work owned by a callback that ignores cancellation. The current MCP adapter also still needs request-signal propagation. Those follow-ups are documented, not claimed complete.

The observation timeout plus the separate final-read budget is the total bounded wait, subject to event-loop scheduling. Existing state normalization is unchanged; confirmed is not being redefined as filled.

No auth, account data, live endpoint, order construction, brokerage mutation, or write gate was exercised or changed. Full MCP remains the personal default. Existing tax-strategy PR #98 remains separate.

Roadmap document

docs/wiring-audit-and-harvest-plan-2026-09-06.md separates source findings, reproduced defects, proposed features, actual verification, and capture requirements. It prioritizes operation-aware retry errors, full cancellation wiring, exact CLI/MCP/provider contracts, current protocol compatibility, and user-visible reconciliation/workbench improvements. It also identifies stale official-service guidance without inventing API schemas or private REST mappings.

Copy link
Copy Markdown
Owner Author

Verified CI result

CI run 347 (34048453294) completed successfully on head 25a1a07b1c93ccec3f93609b5873f5890ec64852.

All eight jobs passed:

  • quality gates, including the high-severity dependency audit;
  • secret scan;
  • build/typecheck and built-workspace Vitest on Node 20 and 22 across Ubuntu, macOS, and Windows;
  • the Linux/Node 20 job also passed the coverage ratchet and generated API-map drift check.

This adds full configured CI evidence to the isolated local compilation and 12 targeted local regression cases described above. It does not certify live Robinhood endpoint behavior, account eligibility, or the proposed roadmap items. No brokerage session or mutation was used. The PR is left open and unmerged.

@zaydiscold
zaydiscold merged commit 7e00865 into main Sep 8, 2026
8 checks passed
@zaydiscold
zaydiscold deleted the codex/robinhood-wiring-audit-2026-09-06 branch September 8, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant