Repository navigation
fix: bound order-watch deadlines; add wiring audit and API harvest plan - #106
Merged
Merged
Conversation
Owner
Author
Verified CI resultCI run 347 ( All eight jobs passed:
This adds full configured CI evidence to the isolated local compilation and 12 targeted local regression cases described above. It does not certify live Robinhood endpoint behavior, account eligibility, or the proposed roadmap items. No brokerage session or mutation was used. The PR is left open and unmerged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
min(timeoutMs, 5000).retrySafe: false; no order is resubmitted.Reproduced baseline
The original lifecycle module was reconstructed locally and verified against Git blob
08ec190e3b7960ed6bca5b8df07243311a49cbb8. A never-settling poll remained pending beyond both a 10 ms observation timeout and explicit cancellation.Validation performed
Explicit boundaries
This stops the observer waiting; it does not cancel underlying HTTP work owned by a callback that ignores cancellation. The current MCP adapter also still needs request-signal propagation. Those follow-ups are documented, not claimed complete.
The observation timeout plus the separate final-read budget is the total bounded wait, subject to event-loop scheduling. Existing state normalization is unchanged;
confirmedis not being redefined as filled.No auth, account data, live endpoint, order construction, brokerage mutation, or write gate was exercised or changed. Full MCP remains the personal default. Existing tax-strategy PR #98 remains separate.
Roadmap document
docs/wiring-audit-and-harvest-plan-2026-09-06.mdseparates source findings, reproduced defects, proposed features, actual verification, and capture requirements. It prioritizes operation-aware retry errors, full cancellation wiring, exact CLI/MCP/provider contracts, current protocol compatibility, and user-visible reconciliation/workbench improvements. It also identifies stale official-service guidance without inventing API schemas or private REST mappings.