Skip to content

feat: integrate guarded money movement executors - #113

Merged
zaydiscold merged 8 commits into
mainfrom
feat/money-movement-integration
Sep 15, 2026
Merged

zaydiscold merged 8 commits into
mainfrom
feat/money-movement-integration

Conversation

@zaydiscold

@zaydiscold zaydiscold commented Sep 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

Adds a complete, account-agnostic money-movement layer across the shared Robinhood engine, CLI, MCP server, route registry, tests, and operator docs.

Deposits

  • Live inventory for every eligible owned destination and linked funding source
  • Standard ACH, instant-bank/RFP, debit-card/DCF, taxable, and IRA contribution metadata
  • Native observed pre_create → create sequencing
  • Current fee/limit/hold/allowance gates and exact receipt reconciliation

Internal transfers

  • Owned account → owned account inventory and execution
  • Taxable ↔ taxable and taxable ↔ retirement semantics kept explicit
  • IRA contribution/distribution fields are never inferred
  • Exact source, destination, amount, direction, and server receipt binding

Withdrawals

  • Standard ACH, instant bank, debit card, and IRA distribution contracts
  • Correct per-rail create vs pre_create → create sequencing
  • DCF capture loading and explicit withholding/distribution eligibility inputs
  • A 2xx without Robinhood's durable transfer_id remains transport-ambiguous

Safety and recovery

  • Dry-run remains the default; live writes still require ROBINHOOD_ALLOW_LIVE_WRITE=1
  • Fresh complete PaymentHub reconciliation immediately before every live send
  • Atomic deterministic intent locks prevent equivalent fresh-ID calls from racing before history is visible
  • Separate atomic operation locks serialize device-approval resumes
  • Intent identity is stable across bearer-token refreshes and ignores semantically inert taxable flags
  • Dispatch state is persisted before continuation; a crash/timeout becomes reconciliation-required, never a blind retry
  • Locks remain through verification-required/ambiguous states and release only after terminal rejection or exact-receipt reconciliation
  • Public fixtures/docs contain no live account, bank, card, cookie, token, or receipt identifiers

Public interfaces

  • CLI: inventory, quote, plan, execute, status, exact receipt, verification, and resume commands
  • MCP: matching deposit, internal-transfer, withdrawal, quote, receipt, verification, and resume tools
  • Deposit quote/plan limitQuote and IRA withdrawal eligibility now have CLI/MCP schema parity

Verification

  • pnpm run quality
  • pnpm run test
    • CLI: 693 passed, 1 skipped across 58 files
    • MCP: 16 passed, 2 skipped
    • Python auth/candidate tests: 18 passed
  • pnpm regression:recent
  • Public portability: 821 tracked files, zero local exact-value findings
  • Shared write-boundary gate: passed
  • Dependency audit at low: zero known vulnerabilities
  • Independent reviews drove fixes for exact withdrawal receipts, post-verification reconciliation, DCF capture selection, mandatory live-history reads, MCP execution-status truth, and cross-process duplicate prevention

Sanitized live acceptance evidence

  • Authenticated inventories enumerate all currently owned destinations and eligible linked funding-source classes
  • Deposit, internal-transfer, and withdrawal dry-run families all returned submitted=false / dry_run
  • A $1 debit-card deposit on a previously untested destination returned an exact provider receipt; independent history readback found one match, completed, fee $0.00
  • A $0.11 internal account transfer independently reconciled by exact provider receipt, one match, completed, fee $0.00
  • No live mutation was repeated during final verification

Related safety work: #100, #90, #88

  • delilah 🌸

@zaydiscold
zaydiscold marked this pull request as draft September 11, 2026 17:08
Delilah added 7 commits September 13, 2026 20:21
Add native Bonfire pre_create/create builders for bank, debit-card, and
owned-account transfers so live writes no longer depend on private capture
fixtures. Journal phone verification under the original request identity,
quote source x rail x destination with live cash/fee gates, and refuse
Roth-origin sends until a distribution contract is captured.

- delilah 🌸
Add the observed IRA questionnaire, fee, and withholding GETs plus the
ira_distribution_data create body for Roth to brokerage and Roth to bank.
Callers must supply distribution type, two-letter state, and withholding
percents; the CLI never infers them. Captures were fail-closed and not sent.

- delilah 🌸
@zaydiscold
zaydiscold force-pushed the feat/money-movement-integration branch from bd1406c to 6e7a1be Compare September 15, 2026 17:44
@zaydiscold
zaydiscold marked this pull request as ready for review September 15, 2026 17:44
Correct IRA deposit metadata, add live DCF withdrawal discovery, and bind standard, instant, card, and retirement withdrawal sequences to their captured contracts. Document provider limit scope and cover the matrix with regressions.

- delilah 🌸
@zaydiscold
zaydiscold force-pushed the feat/money-movement-integration branch from 6e7a1be to 01a46ee Compare September 15, 2026 17:49
@zaydiscold
zaydiscold merged commit 96b3230 into main Sep 15, 2026
8 checks passed
@zaydiscold
zaydiscold deleted the feat/money-movement-integration branch September 15, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant