Skip to content

fix: consolidate portfolio reliability, portable auth, and public onboarding - #114

Merged
zaydiscold merged 4 commits into
mainfrom
fix/portfolio-read-reliability
Nov 8, 2026
Merged

zaydiscold merged 4 commits into
mainfrom
fix/portfolio-read-reliability

Conversation

@zaydiscold

@zaydiscold zaydiscold commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

Portfolio reads could omit secondary-account holdings/history and confuse chart coordinates with investment returns. Bootstrap authentication also invoked bare bash, which can start WSL instead of Git Bash on Windows. This consolidates the read-path fixes, portable authentication entry point, dependency remediation, and public onboarding in one change.

Changes

  • Share paginated, explicitly owned-account equity inventory between CLI and MCP; retain account and order provenance and fail visibly on incomplete reads.
  • Parse performance from signed broker-display values, preserve unavailable returns, distinguish maintenance excess with uncleared deposits, and label concentration denominators.
  • Select an absolute Bash executable for pnpm auth:refresh, preserve the repository working directory and environment, propagate failure, and enforce LF shell files. Existing atomic credential promotion stays intact.
  • Replace the overloaded root README with installation, account selection, MCP JSON configuration, a forced dry-run example, and shared-engine architecture. Add CONTRIBUTING.md and clarify financial interpretation limits.
  • Strengthen MCP protocol annotation checks while retaining the existing tests and full OS/Node CI matrix.
  • Retain the prior dependency remediation and update Hono's Node server to 2.1.3 and minimatch to 11.0.1 for newly reported advisories. No audit suppression or threshold changes.

Validation

On the final source and dependency set: frozen install baseline, build, 705 CLI tests, 18 MCP tests, 5 bootstrap launcher tests, 10 Python authentication tests, quality checks, and coverage ratchets passed. The pnpm 11.13.1 advisory audit reports zero known vulnerabilities. Gitleaks found no leaks in the four PR commits. Cross-platform CI is required before merge; local simulated Windows resolver tests are not a physical Windows acceptance claim.

Scope

The original checkout's unrelated private operator state, untracked investigations, stale dependency edits, speculative archive migration, and test/CI reductions are preserved outside this change. No credentials or private account reports are included. No trading permissions or live-account settings changed.

The repository is already public. This is a source consolidation, not a new npm/tagged release or a claim that all roadmap work is finished. Request-scoped approval (#90), broader mutation verification (#100), tax reconciliation, and repository protection (#86) remain open.

Closes #87.

Zayd and others added 4 commits October 27, 2026 04:00
Update MCP SDK and Zod within their existing major versions, align Vitest and coverage at 4.1.12, and refresh vulnerable security overrides. Include the separate Knip Zod path and regenerate the pnpm 10 lockfile.

Validated zero advisory audit, frozen install, build, 705 CLI and 18 MCP tests with coverage, auth regressions, quality, recent regression gate, and generated API map parity.
@zaydiscold zaydiscold changed the title fix: make portfolio reads reliable and simplify public onboarding fix: consolidate portfolio reliability, portable auth, and public onboarding Nov 8, 2026
@zaydiscold
zaydiscold marked this pull request as ready for review November 8, 2026 22:18
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-08T22:21:39.656631Z da40797 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@zaydiscold
zaydiscold merged commit f14f24f into main Nov 8, 2026
8 checks passed
@zaydiscold
zaydiscold deleted the fix/portfolio-read-reliability branch November 8, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs cleanup: turn the root README into a concise product landing page

1 participant