Repository navigation
fix: consolidate portfolio reliability, portable auth, and public onboarding - #114
Merged
Merged
Conversation
Update MCP SDK and Zod within their existing major versions, align Vitest and coverage at 4.1.12, and refresh vulnerable security overrides. Include the separate Knip Zod path and regenerate the pnpm 10 lockfile. Validated zero advisory audit, frozen install, build, 705 CLI and 18 MCP tests with coverage, auth regressions, quality, recent regression gate, and generated API map parity.
zaydiscold
marked this pull request as ready for review
November 8, 2026 22:18
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Portfolio reads could omit secondary-account holdings/history and confuse chart coordinates with investment returns. Bootstrap authentication also invoked bare
bash, which can start WSL instead of Git Bash on Windows. This consolidates the read-path fixes, portable authentication entry point, dependency remediation, and public onboarding in one change.Changes
pnpm auth:refresh, preserve the repository working directory and environment, propagate failure, and enforce LF shell files. Existing atomic credential promotion stays intact.Validation
On the final source and dependency set: frozen install baseline, build, 705 CLI tests, 18 MCP tests, 5 bootstrap launcher tests, 10 Python authentication tests, quality checks, and coverage ratchets passed. The pnpm 11.13.1 advisory audit reports zero known vulnerabilities. Gitleaks found no leaks in the four PR commits. Cross-platform CI is required before merge; local simulated Windows resolver tests are not a physical Windows acceptance claim.
Scope
The original checkout's unrelated private operator state, untracked investigations, stale dependency edits, speculative archive migration, and test/CI reductions are preserved outside this change. No credentials or private account reports are included. No trading permissions or live-account settings changed.
The repository is already public. This is a source consolidation, not a new npm/tagged release or a claim that all roadmap work is finished. Request-scoped approval (#90), broader mutation verification (#100), tax reconciliation, and repository protection (#86) remain open.
Closes #87.