Revert "fix: do not fail validation for target nodes that don't exist" #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 48ad810. # Conflicts: # src/shapes-graph.js # test/data/data-shapes/custom/manifest.ttl # test/data/data-shapes/custom/targetNodeDoesNotExist.ttl
🦋 Changeset detectedLatest commit: ca93d5a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
==========================================
- Coverage 98.18% 98.17% -0.01%
==========================================
Files 11 11
Lines 2039 2032 -7
Branches 294 292 -2
==========================================
- Hits 2002 1995 -7
Misses 33 33
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Bencher Report| Branch | revert-81 |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) | Throughput | Benchmark Result operations / second (ops/s) (Result Δ%) | Upper Boundary operations / second (ops/s) (Limit %) |
|---|---|---|---|---|---|---|
| BreadCerealsFlourBakedGoods_Consumption__Price_Month - cube | 📈 view plot 🚷 view threshold | 241.39 ns(-12.23%)Baseline: 275.02 ns | 400.41 ns (60.29%) | 📈 view plot 🚷 view threshold | 4.17 ops/s(+11.26%)Baseline: 3.75 ops/s | 5.21 ops/s (79.97%) |
| BreadCerealsFlourBakedGoods_Consumption__Price_Month - observations | 📈 view plot 🚷 view threshold | 141.63 ns(-34.83%)Baseline: 217.32 ns | 478.74 ns (29.58%) | 📈 view plot 🚷 view threshold | 7.03 ops/s(+27.00%)Baseline: 5.54 ops/s | 10.10 ops/s (69.64%) |
| Test standalone-cube-constraint againt SHACL-SHACL | 📈 view plot 🚷 view threshold | 492.00 ns(-16.40%)Baseline: 588.53 ns | 907.38 ns (54.22%) | 📈 view plot 🚷 view threshold | 2.04 ops/s(+15.02%)Baseline: 1.77 ops/s | 2.59 ops/s (78.78%) |
giacomociti
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts changed from PR #81